Fix AutocompleteInput only display the first 1000 choices #7884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
Jun 23, 2022
[skip ci]
fzaninotto
requested changes
Jun 24, 2022
| @@ -160,6 +160,25 @@ export const useList = <RecordType extends RaRecord = any>( | |||
| Object.entries(filterValues).every( | |||
| ([filterName, filterValue]) => { | |||
| const recordValue = get(record, filterName); | |||
|
|
|||
| if (!recordValue) { | |||
There was a problem hiding this comment.
You're testing the value regardless of the filter name. I don't understand what you're doing here. Can you please add a comment to clarify it?
| @@ -935,4 +938,35 @@ describe('<AutocompleteInput />', () => { | |||
| screen.getByText('No options'); | |||
| }); | |||
| }); | |||
|
|
|||
| it('should not display "Dalmatian #1001" when given no `perPage` parameters and a list of 1001 dalmatians', async () => { | |||
There was a problem hiding this comment.
Suggested change
| it('should not display "Dalmatian #1001" when given no `perPage` parameters and a list of 1001 dalmatians', async () => { | |
| it('should limit the number of options to the value of the perPage prop', async () => { |
| expect(screen.queryByText('Dalmatian #1001')).toBeNull(); | ||
| }); | ||
|
|
||
| it('should display "Dalmatian #1001" when given `perPage=1001` parameters and a list of 1001 dalmatians', async () => { |
There was a problem hiding this comment.
In the test description, speak about the feature you're testing, not the dataset you're using
| mutationMode="pessimistic" | ||
| mutationOptions={{ | ||
| onSuccess: data => { | ||
| console.log(data); |
| ); | ||
| }; | ||
|
|
||
| export const VeryLargeOptionsNumber = (props: { |
There was a problem hiding this comment.
Name that Story PerPage, because that's what it demonstrates
|
|
||
| export const VeryLargeOptionsNumber = (props: { | ||
| perPage?: number; | ||
| includeAdmin?: boolean; |
| @@ -276,11 +278,6 @@ If you provided a React element for the optionText prop, you must also provide t | |||
| if (setFilter) { | |||
| return setFilter(filter); | |||
| } | |||
|
|
|||
| if (choicesProp) { | |||
|
Superseded by #7889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7880