Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable <SaveButton/> while Inputs are being validated asynchronously #6288

Merged
merged 8 commits into from
Jun 1, 2021
Merged

Disable <SaveButton/> while Inputs are being validated asynchronously #6288

merged 8 commits into from
Jun 1, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented May 19, 2021

Fixes #4557

djhi
djhi approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fzaninotto
Copy link
Member

Please add a unit test to prove that it fixes the problem.

@WiXSL WiXSL changed the title Fix Disable <SaveButton/> if pristine or validating props are true Fix Disable <SaveButton/> if Inputs are being validated asynchronously May 23, 2021
@WiXSL WiXSL requested a review from djhi May 23, 2021 02:46
@WiXSL
Copy link
Contributor Author

WiXSL commented May 24, 2021

@fzaninotto, I've added a test as requested

@fzaninotto fzaninotto changed the title Fix Disable <SaveButton/> if Inputs are being validated asynchronously Disable <SaveButton/> while Inputs are being validated asynchronously May 31, 2021
@WiXSL WiXSL force-pushed the fix-savebutton-disabled branch from f234ee4 to 5dd29d3 Compare May 31, 2021 22:02
@WiXSL WiXSL requested a review from fzaninotto May 31, 2021 23:47
@fzaninotto fzaninotto merged commit 5d88add into marmelab:master Jun 1, 2021
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.16.0 milestone Jun 1, 2021
@WiXSL WiXSL deleted the fix-savebutton-disabled branch June 1, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

Async validation on field level and form submit button loading
3 participants
@WiXSL @fzaninotto @djhi