[TypeScript] Add the ability to type SimpleList callbacks #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
approved these changes
May 7, 2021
ken1901
pushed a commit
to ken1901/react-admin
that referenced
this pull request
Feb 11, 2023
[TypeScript] Add the ability to type SimpleList callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Many of the
<SimpleList>props are callback that expect aRecordargument. But TypeScript complains when accessing fields of these records, and that forces to add// @ts-ignoreflags.Solution
Make
<SimpleList>generic to accept a Record type.