restore deprecated undoable prop original behavior #6153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Apr 12, 2021
| import PropTypes from 'prop-types'; | ||
| import { Record, RedirectionSideEffect, MutationMode } from 'ra-core'; | ||
|
|
||
| import { ButtonProps } from './Button'; | ||
| import DeleteWithUndoButton from './DeleteWithUndoButton'; | ||
| import DeleteWithConfirmButton from './DeleteWithConfirmButton'; | ||
|
|
||
| const useMutationMode = (mutationMode, undoable) => { |
There was a problem hiding this comment.
Can you extract this in a dedicated file ?
fzaninotto
requested changes
Apr 13, 2021
| import PropTypes from 'prop-types'; | ||
| import { Record, RedirectionSideEffect, MutationMode } from 'ra-core'; | ||
|
|
||
| import { ButtonProps } from './Button'; | ||
| import DeleteWithUndoButton from './DeleteWithUndoButton'; | ||
| import DeleteWithConfirmButton from './DeleteWithConfirmButton'; | ||
|
|
||
| const useMutationMode = (mutationMode, undoable) => { | ||
| useEffect(() => { |
There was a problem hiding this comment.
I'm -1 with this useEffect and the related warnings. A simple function, rather than a hook, will be enough.
|
bump, could you please apply the review? |
djhi
reviewed
Apr 30, 2021
ThieryMichel
force-pushed
the
delete_undoable_retrocompatibility
branch
from
1a589bf to
9028481
Compare
fzaninotto
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For retrocompatibility undoable=false should be on pessimistic mode, currently it is on undoable mode.