Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Remove doc from published react-admin package #10505

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Feb 10, 2025

Problem

We currently include a copy of the docs directory in the published react-admin package. This makes it quite heavy and is probably useless.

Solution

  • remove the command that copy the docs directory when building the package.
  • remove the docs directory from the included files of the package.json for react-admin

Additional Checks

  • The PR targets master for a bugfix, or next for a feature

@@ -57,10 +57,7 @@ build-ra-language-french:

build-react-admin:
@echo "Transpiling react-admin files...";
@rm -rf ./packages/react-admin/docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably keep this one for those of us who have an old copy of the docs

@fzaninotto fzaninotto merged commit 449e6c7 into master Feb 11, 2025
16 checks passed
@fzaninotto fzaninotto deleted the remove-doc-from-react-admin-package branch February 11, 2025 09:43
@fzaninotto fzaninotto added this to the 5.5.4 milestone Feb 11, 2025
@fzaninotto fzaninotto changed the title Remove doc from published react-admin package [Chore] Remove doc from published react-admin package Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants