Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Deprecate mui v6 system props #10463

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented Jan 22, 2025

Problem

MUI System props now need to be put under sx field. https://mui.com/material-ui/migration/migrating-from-deprecated-apis/#system-props

This is not a breaking change as mui v5 also supports putting system props in the sx field instead of the props directly https://v5.mui.com/system/properties/#legend

Solution

We need to use latest guideline in mui v6 without introducing breaking change for users still using mui v5.

Also suggest to apply the codemod through jscodeshift for the packages folder https://next.mui.com/material-ui/migration/migrating-from-deprecated-apis/#system-props

How To Test

Describe the steps required to test the changes

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/AppBar.md Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit 0e4ba98 into marmelab:master Feb 4, 2025
15 checks passed
@fzaninotto
Copy link
Member

Thanks a lot!

@fzaninotto fzaninotto added this to the 5.5.4 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants