-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Deprecate mui v6 system props #10463
Merged
fzaninotto
merged 6 commits into
marmelab:master
from
smeng9:deprecate-mui-v6-system-props
Feb 4, 2025
Merged
[Doc] Deprecate mui v6 system props #10463
fzaninotto
merged 6 commits into
marmelab:master
from
smeng9:deprecate-mui-v6-system-props
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
djhi
requested changes
Feb 3, 2025
fzaninotto
approved these changes
Feb 4, 2025
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MUI System props now need to be put under sx field. https://mui.com/material-ui/migration/migrating-from-deprecated-apis/#system-props
This is not a breaking change as mui v5 also supports putting system props in the sx field instead of the props directly https://v5.mui.com/system/properties/#legend
Solution
We need to use latest guideline in mui v6 without introducing breaking change for users still using mui v5.
Also suggest to apply the codemod through jscodeshift for the packages folder https://next.mui.com/material-ui/migration/migrating-from-deprecated-apis/#system-props
How To Test
Describe the steps required to test the changes
Additional Checks
master
for a bugfix, ornext
for a featureAlso, please make sure to read the contributing guidelines.