Remove redundant optimisation of cache lookup for useGetMany(Aggregate) placeholderData

[wattroll]

This is essentially a revert of commit e4e0f2c. See #7028 for why it was necessary. TanStack/query#6918 included equivalent optimisation (14aa69f), making it redundant here.

The dependency is bumped to be at least @tanstack/[email protected].

[wattroll]

The typechecking errors appear to be caused by bumping react-query version and refer to code that haven't been changed here. I'll have a quick look at them, but should I rather:

a. fix them in this PR (separate commit), or
b. make another PR just fixing the type errors and have it merged first?

I am averse to removing optimisation without bumping the dependency bound since that would be an unnecessarily breaking change in a very subtle performance-impacting way.

[wattroll]

I simply amended yarn.lock and specified the latest react-query version that doesn't trigger any type errors.

[wattroll]

I also have confirmed that all 3 errors when building against latest react-query version appear in places where there is some degree of typechecker dodging. I assume that changes in react-query broke these coercions and they need to be refined or resolved soundly. Specifically:

1. react-admin/packages/ra-core/src/controller/input/useReferenceInputController.ts

   Line 119 in 0538e79

   // @ts-ignore the types of the queryOptions for the getMAny and getList are not compatible

2. react-admin/packages/ra-core/src/dataProvider/useGetList.ts

   Line 176 in 0538e79

   ) as UseQueryResult<RecordType[], Error> & {

3. react-admin/packages/ra-core/src/dataProvider/useGetManyReference.ts

   Line 159 in 0538e79

   ) as UseQueryResult<RecordType[], Error> & {

[wattroll]

Rebased onto master in order to resolve the conflict in yarn.lock

[fzaninotto]

Thanks!

Since you're bumping the required version for a dependency, this change should land in a minor version (e.g., 5.4) rather than a bug fix (e.g., 5.3.2). So please PR against the next branch instead of master.

[wattroll]

It is now rebased onto the next branch. There were no conflicts.

[slax57]

Thanks !