Fix ra-data-graphql
incorrectly warns about deprecated override
option being set
#10138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#10052 - the check whether the
override
prop was used is faulty and warns even when not appropriate.Solution
As suggested in the comments, instead of checking whether
override
is!= null
, we check whether it has keys in it. This way, its default value -{}
won't pass this check, and no warning gets logged.I used
Object.keys(override).length > 0
instead ofObject.keys(override).length
before I favor explicitness over the somewhat wonky JavaScript coercion. I can change this, though.How To Test
Follow the steps described in #10052 with this fixed version.
Additional Checks
master
for a bugfix, ornext
for a featuremake
scripts don't seem to work under Windows, so I had to switch to another platform first, or try to make it run under WSL. I could try that, but I dunno when I find time for such an undertaking.