[RFR]remember list filter when navigating on same entity. #418
Conversation
| $location.path(entityLabel + '/list'); | ||
| $state.go($state.get('list'), { | ||
| entity: _this.entity.name(), | ||
| page: _this.$state.params.page, |
There was a problem hiding this comment.
why don't you use $state instead?
|
Please copy the params only if the target entity is the same as the current entity - otherwise you may apply filters set on the posts list to a list of comments |
|
Also, this PR deserves e2e tests |
ThieryMichel
force-pushed
the
back_to_filtered_list
branch
5 times, most recently
from
fe06bff to
9dee910
Compare
|
Need rebase |
ThieryMichel
force-pushed
the
back_to_filtered_list
branch
from
9dee910 to
5e4cdb4
Compare
|
rebased |
| @@ -15,7 +15,13 @@ define(function () { | |||
| scope.label = scope.label || 'Create'; | |||
|
|
|||
| scope.gotoCreate = function () { | |||
| $state.go($state.get('create'), { 'entity': scope.entity().name() }); | |||
| $state.go($state.get('create'), { | |||
There was a problem hiding this comment.
Why not merging $state.params? like angular.extend($state.params, {/* ... */}); ?
|
Need rebase, again... And can you skip your e2e tests because they don't work on saucelabs (see #445). |
…e/delete/batchdelete page
ThieryMichel
force-pushed
the
back_to_filtered_list
branch
from
5db3f01 to
3c32452
Compare
[RFR]remember list filter when navigating on same entity.
|
Seems to me if you go to show record, and click list to come back, it'll go back to the page with filters. But this is not the case for edit and create view ? Ok, I checked the code, previousState is what we're using to track the page states, therefore it works if you click the list right after show/create/edit. However our create/edit is not one step thing, you normally will click on create and then submit, and then click list, so by then this old state is lost. Unless we can go to list page right after create/edit, I don't think this will be possible. Note: I tried the latest creation hook, and i suggest to make some changes to include previousState in the onSubmitSuccess(), #898 |
save filter page and sort in state when going from list to edit/create/delete/batchdelete page, and restore it when going back to the list view.