[RFR] Refactor View.fields #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThieryMichel
commented
Apr 7, 2015
ThieryMichel
commented
- Make view.fields return an array instead of a literal
- Prepare to remove Field.order method by using it only in View.fields
- add deprecation warning
|
Can you also update changelog and README to show depreciations? |
| var field = view.fields()[fieldName]; | ||
| if (field.name() in restEntry) { | ||
| values[fieldName] = field.getMappedValue(restEntry[field.name()], restEntry); | ||
| // var values = restEntry; |
|
Great job, this really simplifies fields handling, it's much more intuitive. |
ThieryMichel
force-pushed
the
fields_array
branch
from
b005aeb to
48a55b2
Compare
ThieryMichel
force-pushed
the
fields_array
branch
from
48a55b2 to
36cde66
Compare
|
Thanks! |
|
How about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.