Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix Karma tests #361

Merged
merged 2 commits into from
Mar 27, 2015
Merged

[RFR] Fix Karma tests #361

merged 2 commits into from
Mar 27, 2015

Conversation

jpetitcolas
Copy link
Contributor

In WIP. Trying to identify the issue first.

@fzaninotto
Copy link
Member

Any progress?

@jpetitcolas
Copy link
Contributor Author

Not yet. Can't find the issue. I'll look at it more deeply later today.

@jpetitcolas
Copy link
Contributor Author

Succeeded to reproduce, using PhantomJS instead of Chrome with command line:

CI=true grunt test

Looking at a fix.

@jpetitcolas jpetitcolas changed the title [WIP] Fix Karma tests [RFR] Fix Karma tests Mar 27, 2015
@jpetitcolas
Copy link
Contributor Author

Switching to RFR. Tests should finally be green (modulo the current GitHub DDOS attack).

ThieryMichel added a commit that referenced this pull request Mar 27, 2015
@ThieryMichel ThieryMichel merged commit 54cefb5 into master Mar 27, 2015
@ThieryMichel ThieryMichel deleted the fix_tests branch March 27, 2015 17:14
@fzaninotto
Copy link
Member

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants