Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add datatimepicker field #297

Closed
wants to merge 1 commit into from
Closed

[WIP] Add datatimepicker field #297

wants to merge 1 commit into from

Conversation

manuquentin
Copy link
Contributor

  • Add field
  • Add doc

@fzaninotto
Copy link
Member

So far, so good. I'm worried about the kB this is going to add to ng-admin.min.js, we really need to consider #250 soon.

fzaninotto
fzaninotto reviewed Feb 10, 2015
View reviewed changes
src/javascripts/ng-admin.js
@@ -11,9 +11,12 @@ require.config({
'angular-resource': 'bower_components/angular-resource/angular-resource',
'angular-sanitize': 'bower_components/angular-sanitize/angular-sanitize',
'angular-ui-router': 'bower_components/angular-ui-router/release/angular-ui-router',
'bootstrap': 'bower_components/bootstrap/dist/js/bootstrap',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that only bootstrap transitions and collapse are needed at this point (http://eonasdan.github.io/bootstrap-datetimepicker/Installing/).

@fzaninotto
Copy link
Member

Seing the number of added dependencies (jQuery, moment, bootstrap js), I wonder if it's not better to add https://github.com/zhaber/datetimepicker (even though it has inferior UI). Your datetimepicker, better but heavier, could be provided as an extension... Once we know how to handle them (cf #294).

What do you think?

@manuquentin
Copy link
Contributor Author

I've spent 3 hours trying to use zhaber/datetimepicker but apparently it's not compatible with angular 1.3.

I'll search for another directive.

@fzaninotto
Copy link
Member

Ah, bummer. Thanks for trying.

Le 11 févr. 2015 à 18:05, Emmanuel Quentin [email protected] a écrit :

I've spent 3 hours trying to use zhaber/datetimepicker but apparently it's not compatible with angular 1.3.

I'll search for another directive.

—
Reply to this email directly or view it on GitHub.

@fzaninotto
Copy link
Member

Any progress for documentation ?

fzaninotto added a commit that referenced this pull request Mar 5, 2015
@fzaninotto
Introducing datetime field
4a74ad4 
Uses a simple datepicker widget (similar to date field), but allows to
enter time.

Supersedes #297

Also, fixes the date field to skip timezones entirely (refs #345, #347)
@fzaninotto fzaninotto mentioned this pull request Mar 5, 2015
Merged
@fzaninotto
Copy link
Member

Superseded by #348

@fzaninotto fzaninotto closed this Mar 6, 2015
@fzaninotto fzaninotto deleted the add_datetime_picker branch March 6, 2015 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuquentin @fzaninotto