Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sass filepath in example #1289

Closed
wants to merge 4 commits into from

Conversation

collinforrester
Copy link

No description provided.

@Kmaschta
Copy link
Contributor

Kmaschta commented Jan 7, 2017

Thank you for taking the time to do a PR.

The SASS file issue (#1238) was fixed by my PR #1261 and will be deployed with the next major version ASAP.

The postinstall script doesn't work on your machine?
Please open an issue or make an isolated PR.

Idem for the angular-numeraljs update. What's the issue?

Finally, you cannot install the project directly from GitHub without the build step which is ran before the NPM publication.

I close the PR for the reasons listed above, it's better to make multiple tiny PR.
Thanks again!

@Kmaschta Kmaschta closed this Jan 7, 2017
@collinforrester
Copy link
Author

Sorry for the multiple changes! I forgot I submitted the PR on master and I kept making changes to it.

angular-numeraljs is depending on a version of numeral that isn't importing correctly with webpack. The issue is described here and fixed in the most recent version of numeraljs.

I had forked this project and angular-numeraljs in an attempt to update all the dependencies and test a build like that.

Thanks for responding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants