Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix non-dev dependencies #1189

Merged
merged 11 commits into from
Sep 19, 2016
Merged

[RFR] Fix non-dev dependencies #1189

merged 11 commits into from
Sep 19, 2016

Conversation

jpetitcolas
Copy link
Contributor

As it breaks other projects because of missing dependencies (for instance admin-config one).

Still in WIP as I am testing it on a project rewrite.

"angular-numeraljs": "^1.1.6",
"angular-sanitize": "^1.3.15",
"angular-translate": "^2.11.0",
"angular-ui-bootstrap": "~1.2.1",
"angular-ui-codemirror": "^0.3.0",
"angular-ui-codemirror": "jpetitcolas/ui-codemirror#di",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix some strict DI errors, preventing JSON field to be colored.

@jpetitcolas
Copy link
Contributor Author

Should be fine now. Can someone give it a try using this branch?

@Phocea
Copy link
Contributor

Phocea commented Sep 15, 2016

Happy to report that I did not face any more issues using this branch!

Since I am also using webpack and babel. I also managed to make this work without the transpiled libs, by using an alias and including the source of ng-admin.
If you think this is worth mentioning I will gladly add this to the documentation once this branch is merged.
Thanks @jpetitcolas !

@jpetitcolas
Copy link
Contributor Author

@Phocea: Glad to read it! :)

I voluntarily did not mention it. Indeed, if you use Babel, you can either use src/ (ES6 files) or lib/ (ES5 files). But if you don't, you can still use ES5. And as this is the default location of the lib (at least once published on npm), it should be fine.

@fzaninotto: switching it to RFR. We should release an alpha5.1 ASAP if everything is fine for you.

@jpetitcolas jpetitcolas changed the title [WIP] Fix non-dev dependencies [RFR] Fix non-dev dependencies Sep 15, 2016
@jpetitcolas jpetitcolas added this to the 1.0 milestone Sep 19, 2016
@@ -1,4 +1,5 @@
var ExtractTextPlugin = require('extract-text-webpack-plugin');
var path = require('path');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants