-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Fix non-dev dependencies #1189
Conversation
ab17da5
to
483a4f1
Compare
e62ddda
to
52ccb93
Compare
"angular-numeraljs": "^1.1.6", | ||
"angular-sanitize": "^1.3.15", | ||
"angular-translate": "^2.11.0", | ||
"angular-ui-bootstrap": "~1.2.1", | ||
"angular-ui-codemirror": "^0.3.0", | ||
"angular-ui-codemirror": "jpetitcolas/ui-codemirror#di", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix some strict DI errors, preventing JSON field to be colored.
Should be fine now. Can someone give it a try using this branch? |
Happy to report that I did not face any more issues using this branch! Since I am also using webpack and babel. I also managed to make this work without the transpiled libs, by using an alias and including the source of ng-admin. |
@Phocea: Glad to read it! :) I voluntarily did not mention it. Indeed, if you use Babel, you can either use @fzaninotto: switching it to RFR. We should release an |
@@ -1,4 +1,5 @@ | |||
var ExtractTextPlugin = require('extract-text-webpack-plugin'); | |||
var path = require('path'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used
As it breaks other projects because of missing dependencies (for instance
admin-config
one).Still in WIP as I am testing it on a project rewrite.