fixes

keel_telegram_bot/client/types.py

@@ -24,7 +24,7 @@ def from_value(value: str):
         """
         if value.startswith("@every "):
             value = value.split(" ")[1]
-        duration = parse_golang_duration(value)
+        duration = parse_golang_duration(value.strip())
         return PollSchedule(duration)
 
     def value(self):
@@ -55,7 +55,7 @@ class Provider(enum.Enum):
     Helm = "helm"
 
     @staticmethod
-    def from_value(value: str):
+    def from_value(value: str) -> "Provider" or None:
         """
         Get the enum from a value
         :param value: the value to convert
@@ -64,7 +64,7 @@ def from_value(value: str):
         for provider in Provider:
             if provider.value.lower() == value.lower():
                 return provider
-        raise Exception(f"Unknown provider value: {value}")
+        return None
 
     def __str__(self):
         return self.value
@@ -82,7 +82,7 @@ class Trigger(enum.Enum):
     Approval = "approval"
 
     @staticmethod
-    def from_value(value: str):
+    def from_value(value: str) -> "Trigger" or None:
         """
         Get the enum from a value
         :param value: the value to convert
@@ -91,7 +91,7 @@ def from_value(value: str):
         for trigger in Trigger:
             if trigger.value.lower() == value.lower():
                 return trigger
-        raise Exception(f"Unknown trigger value: {value}")
+        return None
 
     def __str__(self):
         return self.value

tests/test_dummy.py

@@ -1,3 +1,4 @@
+from keel_telegram_bot.client import parse_golang_duration, timedelta_to_golang_duration
 from keel_telegram_bot.client.approval import Approval
 from keel_telegram_bot.client.resource import Resource
 from keel_telegram_bot.util import approval_to_str, resource_to_str
@@ -9,6 +10,14 @@ class DummyTest(TestBase):
     def test_dummy(self):
         self.assertTrue(True)
 
+    def test_parse_golang_duration(self):
+        duration = parse_golang_duration("24h")
+        print(duration)
+
+        golang_duration_str = timedelta_to_golang_duration(duration)
+        print(golang_duration_str)
+
+
     def test_approval_format(self):
         approval = Approval.from_dict({
             "id": "48d6da3e-e4c9-4d12-8562-b7975e805d80",