feat: pretty printing without color #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new flag `--color` that decides whether colors are printed while pretty-printing is on. Valid values are `on`, `off` and `auto`, which is the default. In the future, there is the possibility of autodetecting from TTY settings, but at the time of writing `auto` means `on`. The flags `-c` and `-C` can also be used to toggle color on/off respectively. NB: Currently, only applies to EDN printing. Additionally tests the pretty-printing with multiple line case, and ANSI color escape sequences.
markus-wa
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15.
Introduce a new flag
--colorthat decides whether colors are printed while pretty-printing is on. Valid values areon,offandauto, which is the default. In the future, there is the possibility of autodetecting from TTY settings, but at the time of writingautomeanson.The flags
-cand-Ccan also be used to toggle color on/off respectively.NB: Currently, only applies to EDN printing.
Additionally tests the pretty-printing with multiple line case, and ANSI color escape sequences.
I'm open for any kinds of suggestions and styling tips. I'm not sure if
-cand-Coptions make sense. They introduce additional complexity, at least as implemented here. Also maybe handling ofautois extra. What do you think?