Add templatetags to clean HTML within django templates #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you @wes-otf - very grateful for this. I've not had chance to get these going yet so this is a real help! |
marksweb
requested changes
Dec 19, 2023
|
|
||
|
|
||
| @register.filter(name="nh3") | ||
| def nh3_value(value: str | None, tags: str | None = None) -> SafeText: |
There was a problem hiding this comment.
Can you add a docstring on this please? Nothing complex, just something basic that descibes the fact it takes a value and will run clean on it & return a safe value to include in the template.
There was a problem hiding this comment.
Just added! Not sure if there's a specific format you prefer so I can add to it if you have a preference. Cheers!
marksweb
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the original django-bleach as a guide to implement nh3 template tags that work similar to how the bleach tags did. Tags can be used in templates as a django filter to clean strings of HTML. Django settings of
NH3_ALLOWED_TAGS,NH3_ALLOWED_ATTRIBUTES, andNH3_STRIP_COMMENTSto specify custom nh3 params. Unit tests were also implemented to test all newly added functionality.Thanks for your work on this project @marksweb! This will be super useful as bleach is gradually deprecated.