-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support discouraged but allowed "$id" values #80
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 92.49% 92.49% -0.01%
==========================================
Files 21 22 +1
Lines 1999 2024 +25
Branches 424 428 +4
==========================================
+ Hits 1849 1872 +23
- Misses 96 98 +2
Partials 54 54
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
OK I think I got everything, but of course let me know if I missed something. |
Thanks, just a couple of things: a change log entry seems to have snuck into 0.10.0, and just a reminder to double quote the strings in JSONSchema._bootstrap |
That should be everything now. |
Non-normalized URIs and (prior to draft-next) URis with empty fragments are allowed. The official test suite does not pick up these issues, so additional tests have been included.
Fixes #69: Non-normalized URIs and (prior to draft-next) URis with empty fragments are allowed. The official test suite does not pick up these issues, so additional tests have been included.