Add docker-compose.healthcheck.yml #384

rangerz · 2021-02-01T09:52:11Z

According to the HEALTHCHECK for docker containers I mentioned in here

@markshust, please rebuild all of php (7.3, 7.4, 8.0) and elasticsearch(6.8, 7.6) images. Thanks 👍

In bin/status also can view all health status

magento2.test git:(master) ✗ ./bin/status                                                        git:(master|●4✚2…5
            Name                          Command                  State                         Ports
------------------------------------------------------------------------------------------------------------------------
magento2test_app_1             /docker-entrypoint.sh ngin ...   Up (healthy)   80/tcp, 0.0.0.0:80->8000/tcp,
                                                                               0.0.0.0:443->8443/tcp
magento2test_db_1              /docker-entrypoint.sh --ma ...   Up (healthy)   0.0.0.0:3306->3306/tcp
magento2test_elasticsearch_1   /usr/local/bin/docker-entr ...   Up (healthy)   0.0.0.0:9200->9200/tcp,
                                                                               0.0.0.0:9300->9300/tcp
magento2test_mailhog_1         MailHog                          Up (healthy)   0.0.0.0:55038->1025/tcp,
                                                                               0.0.0.0:8025->8025/tcp
magento2test_phpfpm_1          docker-php-entrypoint php-fpm    Up (healthy)   9000/tcp, 9001/tcp
magento2test_rabbitmq_1        docker-entrypoint.sh rabbi ...   Up (healthy)   15671/tcp, 0.0.0.0:15672->15672/tcp,
                                                                               25672/tcp, 4369/tcp, 5671/tcp,
                                                                               0.0.0.0:5672->5672/tcp
magento2test_redis_1           docker-entrypoint.sh redis ...   Up (healthy)   6379/tcp

Refs:
magento/magento-cloud-docker
sun-asterisk-research/docker-php

markshust

Very cool, thanks for this. Some questions/comments posted.

markshust · 2021-02-03T14:23:59Z

compose/bin/setup

-  --elasticsearch-host=$ES_HOST \
-  --elasticsearch-port=$ES_PORT \
+  --elasticsearch-host=elasticsearch \
+  --elasticsearch-port=9200 \


We'll want to back out this update so a user can override the Elasticsearch host/port with env vars.

ok, I will recover this part.

But I think this setting is very common.
If someone need change Elasticsearch host/port, change here is not enough.

docker-compose.yml (just guess, not test yet)

elasticsearch: image: markoshust/magento-elasticsearch:7.6.2-2 ports: - "9200:9200" # this also need to change - "9300:9300" environment: - "discovery.type=single-node" - ES_HOST=elasticsearch # add new value - ES_PORT=9200 # add new value

Yep, I'd avoid the vars being set here though and set defaults within the bash file (see #384 (comment)). But, this is how & where someone would override these vars. This would be useful to add to the documentation.

I think this push request (commit) should only keep changes about HEALTHCHECK.
For other environmental variables, I will create another one for it.

markshust · 2021-02-03T14:24:23Z

compose/bin/setup

@@ -3,14 +3,10 @@ set -o errexit
 source env/db.env
 BASE_URL=${1:-magento2.test}

-ES_HOST=elasticsearch
-ES_PORT=9200


Need to add these back in

I think this is where we need updates. These settings are file, but need to pull in from envvar if it exists.

I didn't test but something like this pseudo code may work:

ES_HOST="${ES_HOST:=elasticsearch}" ES_PORT="${ES_PORT:=9200}"

This way we don't need to define anything in the XML files.

On second thought, maybe be better to create an env/elasticsearch.env file for these similar to https://github.com/markshust/docker-magento/blob/master/compose/env/db.env

@markshust I think this push request (commit) should only keep changes about HEALTHCHECK.
For other environmental variables, I will create another one for it.

markshust · 2021-02-03T14:25:16Z

compose/docker-compose.yml

@@ -19,12 +19,27 @@ services:
      - appdata:/var/www/html
      - sockdata:/sock
      - ssldata:/etc/nginx/certs
+    healthcheck:
+      test: 'curl --fail http://127.0.0.1:8000'
+      interval: 1m30s


Why is the interval a different value from the docker-compose.dev.yml file?

I think remove all interval, timeout, and start-period will be fine.
Using their default value may a better choice

The options that can appear before CMD are:

--interval=DURATION (default: 30s) --timeout=DURATION (default: 30s) --start-period=DURATION (default: 0s) --retries=N (default: 3)

Cool, definitely prefer the defaults 👍

markshust · 2021-02-03T14:26:02Z

compose/docker-compose.yml

+    healthcheck:
+      test: 'curl --fail http://127.0.0.1:8000'
+      interval: 1m30s
+      timeout: 10s


Same with timeout, I would think these would be consistent between the files unless there was some other reason to do so (which should probably then be documented).

Remove all interval, timeout, and start-period, and use default value.

markshust · 2021-02-03T14:27:13Z

compose/docker-compose.yml

@@ -53,6 +78,11 @@ services:
      - "5672:5672"
    volumes:
      - rabbitmqdata:/var/lib/rabbitmq
+    healthcheck:
+      test: 'rabbitmq-diagnostics -q ping'
+      interval: 30s


The healthcheck params are repeated a few times, can we make this into a YAML anchor like volumes are done?

Remove all interval, timeout, and start-period, and use default value.

markshust · 2021-10-14T17:52:53Z

@rangerz this has been sitting here a long time. Should it be worked on & merged in? It's a bit invasive, I want to make sure we need this, as there seems to be many moving pieces to implement this. I've really never had a problem with my Docker containers being in an unhealthy state.

rangerz · 2022-10-13T04:19:07Z

@markshust

Forget the above message

I added docker-compose.healthcheck.yml for bin/start without until statement in bash script

Please review it.

markshust · 2022-10-20T16:11:16Z

Hi @rangerz, all looks good! But I don't see any additions to bin/start. Did you want me to merge this for testing, or is this missing an update in bin/start?

I just merged your other big PR in for docker-compose/docker compose, so perhaps that needed to be merged in first?

rangerz · 2022-10-20T21:36:21Z

@markshust Yes, here is waiting for the bin/docker-compose commit.

It's updated to put docker-compose.healthcheck.yml into bin/docker-compose and then remove until wait for RabbitMQ and Elasticsearch services

markshust · 2022-10-24T16:58:53Z

Awesome... this is sweet!!! 🧡🧡🧡

markshust requested changes Feb 3, 2021

View reviewed changes

rangerz force-pushed the healthcheck branch from 37aa25f to 3270fac Compare February 3, 2021 18:10

rangerz closed this Oct 13, 2022

rangerz force-pushed the healthcheck branch from 3270fac to 7edcc6d Compare October 13, 2022 04:05

rangerz reopened this Oct 13, 2022

rangerz changed the title ~~Add healthcheck for all containers~~ Add docker-compose.healthcheck.yml Oct 13, 2022

rangerz requested a review from markshust October 17, 2022 17:22

markshust approved these changes Oct 20, 2022

View reviewed changes

Add docker-compose.healthcheck.yml

3a54f63

rangerz force-pushed the healthcheck branch from 66e4a36 to 3a54f63 Compare October 20, 2022 21:30

markshust approved these changes Oct 24, 2022

View reviewed changes

markshust merged commit ba7ec89 into markshust:master Oct 24, 2022

rangerz deleted the healthcheck branch December 10, 2022 09:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add docker-compose.healthcheck.yml #384

Add docker-compose.healthcheck.yml #384

rangerz commented Feb 1, 2021

markshust left a comment

markshust Feb 3, 2021

rangerz Feb 3, 2021

markshust Feb 4, 2021

rangerz Mar 31, 2021

markshust Feb 3, 2021

markshust Feb 4, 2021

markshust Feb 4, 2021

rangerz Feb 5, 2021

markshust Feb 3, 2021

rangerz Feb 3, 2021

markshust Feb 4, 2021

markshust Feb 3, 2021

rangerz Feb 3, 2021

markshust Feb 4, 2021

markshust Feb 3, 2021

rangerz Feb 3, 2021

markshust Feb 4, 2021

markshust commented Oct 14, 2021

rangerz commented Oct 13, 2022 •

edited

Loading

markshust commented Oct 20, 2022

rangerz commented Oct 20, 2022 •

edited

Loading

markshust commented Oct 24, 2022

Add docker-compose.healthcheck.yml #384

Add docker-compose.healthcheck.yml #384

Conversation

rangerz commented Feb 1, 2021

markshust left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markshust commented Oct 14, 2021

rangerz commented Oct 13, 2022 • edited Loading

markshust commented Oct 20, 2022

rangerz commented Oct 20, 2022 • edited Loading

markshust commented Oct 24, 2022

rangerz commented Oct 13, 2022 •

edited

Loading

rangerz commented Oct 20, 2022 •

edited

Loading