validator for rotate processor

markevans · May 15, 2021 · bcbe125 · bcbe125
1 parent bf14fb1
commit bcbe125
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/dragonfly/image_magick/plugin.rb b/lib/dragonfly/image_magick/plugin.rb
@@ -5,6 +5,7 @@
 require "dragonfly/image_magick/processors/encode"
 require "dragonfly/image_magick/processors/thumb"
 require "dragonfly/image_magick/commands"
+require "dragonfly/param_validators"
 
 module Dragonfly
   module ImageMagick
@@ -61,6 +62,7 @@ def call(app, opts = {})
         app.add_processor :encode, Processors::Encode.new
         app.add_processor :thumb, Processors::Thumb.new
         app.add_processor :rotate do |content, amount|
+          ParamValidators.validate!(amount, &ParamValidators.is_number)
           Commands.convert(content, "-rotate #{amount}")
         end
 

diff --git a/spec/dragonfly/image_magick/plugin_spec.rb b/spec/dragonfly/image_magick/plugin_spec.rb
@@ -116,6 +116,12 @@
         image.width.should == 355
         image.height.should == 280
       end
+
+      it "disallows bad parameters" do
+        expect {
+          image.rotate!("90 -write bad.png").apply
+        }.to raise_error(Dragonfly::ParamValidators::InvalidParameter)
+      end
     end
   end