Skip to content

fix: prevent single-tilde strikethrough false positives #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UziTech merged 10 commits into from
Mar 20, 2026
Merged

fix: prevent single-tilde strikethrough false positives #3910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
21ab0b6
fix: prevent single-tilde strikethrough false positives
Mar 10, 2026
a92a300
fix: use unicode alphanumeric check in strikethrough delimiter
Mar 10, 2026
b5d0a7f
fix: also check char before closing tilde to preserve valid strikethr…
Mar 11, 2026
e24034e
Refactor strikethrough rule
UziTech Mar 15, 2026
aa34586
Remove tokenizer changes
UziTech Mar 15, 2026
ddf7873
Fix formatting in Tokenizer.ts
UziTech Mar 15, 2026
a720f00
Update del_strikethrough.md with new test cases
UziTech Mar 15, 2026
70e380a
Fix strikethrough HTML syntax in del_strikethrough.html
UziTech Mar 15, 2026
102bda0
Update Higgs boson mass and add new entry
UziTech Mar 15, 2026
350f063
Add new paragraph with Higgs boson mass details
UziTech Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,6 @@ const _punctuationGfmStrongEm = /(?!~)[\p{P}\p{S}]/u;
const _punctuationOrSpaceGfmStrongEm = /(?!~)[\s\p{P}\p{S}]/u;
const _notPunctuationOrSpaceGfmStrongEm = /(?:[^\s\p{P}\p{S}]|~)/u;

// GFM allows * and _ inside strikethrough
const _punctuationGfmDel = /(?![*_])[\p{P}\p{S}]/u;
const _punctuationOrSpaceGfmDel = /(?![*_])[\s\p{P}\p{S}]/u;
const _notPunctuationOrSpaceGfmDel = /(?:[^\s\p{P}\p{S}]|[*_])/u;

// sequences em should skip over [title](link), `code`, <html>
const blockSkip = edit(/link|precode-code|html/, 'g')
.replace('link', /\[(?:[^\[\]`]|(?<a>`+)[^`]+\k<a>(?!`))*?\]\((?:\\[\s\S]|[^\\\(\)]|\((?:\\[\s\S]|[^\\\(\)])*\))*\)/)
Expand Down Expand Up @@ -338,7 +333,7 @@ const emStrongRDelimUnd = edit(

// Tilde left delimiter for strikethrough (similar to emStrongLDelim for asterisk)
const delLDelim = edit(/^~~?(?:((?!~)punct)|[^\s~])/, 'u')
.replace(/punct/g, _punctuationGfmDel)
.replace(/punct/g, _punctuation)
.getRegex();

// Tilde delimiter patterns for strikethrough (similar to asterisk)
Expand All @@ -352,9 +347,9 @@ const delRDelimCore =
+ '|notPunctSpace(~~?)(?=notPunctSpace)'; // (6) a~~a can be either Left or Right Delimiter

const delRDelim = edit(delRDelimCore, 'gu')
.replace(/notPunctSpace/g, _notPunctuationOrSpaceGfmDel)
.replace(/punctSpace/g, _punctuationOrSpaceGfmDel)
.replace(/punct/g, _punctuationGfmDel)
.replace(/notPunctSpace/g, _notPunctuationOrSpace)
.replace(/punctSpace/g, _punctuationOrSpace)
.replace(/punct/g, _punctuation)
.getRegex();

const anyPunctuation = edit(/\\(punct)/, 'gu')
Expand Down
2 changes: 2 additions & 0 deletions test/specs/new/del_flanking.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
<p>Between (~1.34) and (~5.4)</p>
<p>~ test~</p>
<p>~test ~</p>
<p>The mass of the Higgs boson is ~125 GeV, while the top quark is <strong>~173 GeV</strong></p>
<p>~~1 <strong>~~2</strong></p>
4 changes: 4 additions & 0 deletions test/specs/new/del_flanking.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@ Between (~1.34) and (~5.4)
~ test~

~test ~

The mass of the Higgs boson is ~125 GeV, while the top quark is **~173 GeV**

~~1 **~~2**
4 changes: 4 additions & 0 deletions test/specs/new/del_strikethrough.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,8 @@

<p>test~~</p>

<p><del>1 a</del>2</p>

<p><del>1 a</del>2</p>

<pre><code class="language-test~~~"></code></pre>
4 changes: 4 additions & 0 deletions test/specs/new/del_strikethrough.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,8 @@ test~~

test~~

~1 a~2

~~1 a~~2

~~~test~~~