Skip to content

render code with and without language with the trailing newline - #1670

Merged
UziTech merged 1 commit into
markedjs:masterfrom
devoto13:code-newline
May 11, 2020
Merged

render code with and without language with the trailing newline#1670
UziTech merged 1 commit into
markedjs:masterfrom
devoto13:code-newline

Conversation

@devoto13

@devoto13 devoto13 commented May 10, 2020

Copy link
Copy Markdown
Contributor

Marked version:

1.0.0

Markdown flavor: n/a

Expectation

Code blocks with and without language are both rendered with the trailing new line.

Result

Code block with language has trailing newline, but code block without language does not.

What was attempted

?

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR)

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel

vercel Bot commented May 10, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/e5nqmxelz
✅ Preview: https://markedjs-git-fork-devoto13-code-newline.markedjs.now.sh

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UziTech UziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚢

@UziTech
UziTech merged commit 31f8379 into markedjs:master May 11, 2020
@UziTech UziTech mentioned this pull request May 16, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants