Skip to content

add browser field to point to es5 - #1661

Merged
styfle merged 1 commit into
markedjs:masterfrom
UziTech:browser-field
May 4, 2020
Merged

add browser field to point to es5#1661
styfle merged 1 commit into
markedjs:masterfrom
UziTech:browser-field

Conversation

@UziTech

@UziTech UziTech commented May 2, 2020

Copy link
Copy Markdown
Member

Marked version: 1.0.0

Description

Add browser field to package.json that points to lib/marked.js so webpack will use es5 version to bundle for browsers.

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel

vercel Bot commented May 2, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/ju4wzqb8l
✅ Preview: https://markedjs-git-fork-uzitech-browser-field.markedjs.now.sh

@UziTech
UziTech requested review from davisjam, joshbruce and styfle May 3, 2020 21:44

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this will fix some users and break others, but lets give it a shot 😅

@styfle
styfle merged commit a1679fa into markedjs:master May 4, 2020
This was referenced May 16, 2020
@UziTech
UziTech deleted the browser-field branch June 17, 2020 17:54
@boazy boazy mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add browser field to package.json

3 participants