fix: renderer.code includes space at beginning of each line of code

[Scrum]

Description

• Fixes renderer.code includes space at beginning of each line of code, issue renderer.code includes space at beginning of each line of code #1488

Contributor

• Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR)

Committer

In most cases, this should be a different person than the contributor.

• Draft GitHub release notes have been updated.
• CI is green (no forced merge required).
• Merge PR

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/2i2a4afnt
✅ Preview: https://markedjs-git-fork-scrum-fix-render-code.markedjs.now.sh

[Scrum]

@UziTech @styfle LGTM

[UziTech]

It looks like that test passes without the fix.

Our tests use @markedjs/html-differ to compare html and it is probably removing the space before checking. You can try writing a unit test to test the exact output.

[Scrum]

@UziTech Hi

You can try writing a unit test to test the exact output.

done

[UziTech]

I was thinking of adding an option like that to the spec tests 👍

[UziTech]

The text should be fixed when creating the token instead of when rendering. If you merge the latest changes you can change the Tokenizer.fences function to fix token.text before parsing.

marked/src/Tokenizer.js

Lines 77 to 87 in 904c974

	fences(src) {
	const cap = this.rules.block.fences.exec(src);
	if (cap) {
	return {
	type: 'code',
	raw: cap[0],
	lang: cap[2] ? cap[2].trim() : cap[2],
	text: cap[3] || ''
	};
	}
	}

And you should inline the fix instead of adding a helper since the code is only going to run in one place. No need for the extra function call.

[Scrum]

@UziTech I don’t quite understand, does this relate exactly to my task?

[UziTech]

Yes, currently you are taking the text from the token and fixing it before sending it to the renderer.

I'm suggesting that you fix the text before it goes into the token so we can still just take the text from the token and send it to the renderer without changing it.

[Scrum]

ok now understand, to save the contract

[Scrum]

@UziTech done

[UziTech]

If you merge the latest changes from master you will see a new file src/Tokenizer.js. This fix should go in that file.

[Scrum]

@UziTech done

[Scrum]

@UziTech @styfle Thank you for making me wiser and the code cleaner

[UziTech]

almost ready

[UziTech]

Looks great. Thanks for sticking with it. 🎉

[Scrum]

@styfle LGTM

[styfle]

Thanks!