Skip to content

fix: Italics modifier (_) breaks links containing underscores - #1641

Merged
styfle merged 2 commits into
markedjs:masterfrom
Scrum:fix/italics-modifier
Apr 14, 2020
Merged

fix: Italics modifier (_) breaks links containing underscores#1641
styfle merged 2 commits into
markedjs:masterfrom
Scrum:fix/italics-modifier

Conversation

@Scrum

@Scrum Scrum commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

Description

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR)

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel

vercel Bot commented Apr 13, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/markedjs/markedjs/pyftzc0xw
✅ Preview: https://markedjs-git-fork-scrum-fix-italics-modifier.markedjs.now.sh

@UziTech UziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep up the good work! 🚀

@Scrum

Scrum commented Apr 14, 2020

Copy link
Copy Markdown
Contributor Author

@styfle LGTM

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle
styfle merged commit 6c538a1 into markedjs:master Apr 14, 2020
@Scrum
Scrum deleted the fix/italics-modifier branch April 14, 2020 14:12
@UziTech UziTech mentioned this pull request Apr 20, 2020
12 tasks
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
fix: Italics modifier (_) breaks links containing underscores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants