fix: Intra-word emphasis can match the wrong asterisks - #1636
Merged
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/markedjs/markedjs/qba5ws1f2 |
Member
|
@davisjam could you check if the new regex is vulnerable to ReDos? |
Contributor
Author
UziTech
approved these changes
Apr 10, 2020
UziTech
left a comment
UziTech
left a comment
Member
There was a problem hiding this comment.
It doesn't looks like this changes the structure of the regex so if it wasn't vulnerable before than it shouldn't be now.
Good work! 💯
Closed
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
fix: Intra-word emphasis can match the wrong asterisks
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
fix: Intra-word emphasis can match the wrong asterisks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.