Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit in what is requested for users #1236

Merged
merged 5 commits into from
Apr 22, 2018
Merged

Be more explicit in what is requested for users #1236

merged 5 commits into from
Apr 22, 2018

Conversation

joshbruce
Copy link
Member

Marked version: 0.3.19

Markdown flavor: n/a

Description

In response to #1235

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

styfle
styfle previously approved these changes Apr 21, 2018
@Martii
Copy link
Contributor

Martii commented Apr 22, 2018

Let's role play for a moment. Consider being a Userscript Author. One of my commit messages said that I didn't hyperlink my name/nick. So a thought might be to improve GH is to write a Userscript that hyperlinks the @mentions in .md files. Userscripts usually improve site deficiencies and can sometimes work around an issue like we ran into.

Alternatively... using "Individual or Organization" really seems to fit the nomenclature of GH... @Martii and @OpenUserJS respectively (if I did "at" plus OpenUserJS.org that could potentially wreak havoc including if GH adds the feature down the line... potentially sending off an email. Organization names don't do that to my knowledge)... This is why I did the initial @ albeit it was on our project mistakenly. So do you think there is a different set of words for this to fit into your idea of this column header to help improve the communication for submissions? ❓

Also if you wouldn't mind please doing a "John Doe" equivalent line in a comment just so we're on the same page that would be helpful for me to understand where you are heading. (http://example.com is a good url)

Copy link
Contributor

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@styfle styfle merged commit c0091ef into markedjs:master Apr 22, 2018
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
* Be more explicit in what is requested for users

* Minor language change

* typo

* Table alignment

* typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants