Update highlight.js examples to new, preferred, calling convention. #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzrin
reviewed
Apr 22, 2021
| @@ -152,7 +152,7 @@ var md = require('markdown-it')({ | |||
| highlight: function (str, lang) { | |||
| if (lang && hljs.getLanguage(lang)) { | |||
| try { | |||
| return hljs.highlight(lang, str).value; | |||
| return hljs.highlight(str, { language: lang).value; | |||
| } catch (__) {} | |||
|
Can i close this and do update myself, including demo? Demo needs similar changes too https://github.com/markdown-it/markdown-it/blob/master/support/demo_template/index.js#L94 + rebuild |
|
Hi Puzrin. Sure, feel free! I'm just happy to help. Sorry about the typo! |
puzrin
pushed a commit
that referenced
this pull request
Apr 22, 2021
|
Done. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See highlightjs/highlight.js#2277
This prevents the message "Deprecated as of 10.7.0. highlight(lang, code, ...args) has been deprecated. Deprecated as of 10.7.0. Please use highlight(code, options) instead. highlightjs/highlight.js#2277" from appearing on the console which then appeared in my website as I simple wrote "node index.js > blah.html"!