Skip to content

feat: add HTTP client option to OAuthConfig #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2025
Merged

feat: add HTTP client option to OAuthConfig #616

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4138fc
feat: add HTTP client option to OAuthConfig
sd2k Oct 13, 2025
d1d4fc1
Use conventional comment on HTTPClient
sd2k Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion client/transport/oauth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ type OAuthConfig struct {
AuthServerMetadataURL string
// PKCEEnabled enables PKCE for the OAuth flow (recommended for public clients)
PKCEEnabled bool
// An optional HTTP client to use for requests.
// If not provided, a default HTTP client will be used.
HTTPClient *http.Client
}

// TokenStore is an interface for storing and retrieving OAuth tokens.
Expand Down Expand Up @@ -151,10 +154,13 @@ func NewOAuthHandler(config OAuthConfig) *OAuthHandler {
if config.TokenStore == nil {
config.TokenStore = NewMemoryTokenStore()
}
if config.HTTPClient == nil {
config.HTTPClient = &http.Client{Timeout: 30 * time.Second}
}

return &OAuthHandler{
config: config,
httpClient: &http.Client{Timeout: 30 * time.Second},
httpClient: config.HTTPClient,
}
}

Expand Down
Loading