chore: remove unused variables and type arguments

[pottekkat]

Description

Removes unused variables and unnecessary type arguments from the codebase.

No functional change, only to prevent gopls from throwing these warnings.

Also breaks up long lines into multiple lines for better readability. This was done automatically by the formatter. I think it makes the code better, but I can remove it if it's an issue.

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• MCP spec compatibility implementation
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code refactoring (no functional changes)
• Performance improvement
• Tests only (no functional changes)
• Other (please describe):

Checklist

• My code follows the code style of this project
• I have performed a self-review of my own code
• I have added tests that prove my fix is effective or that my feature works
• I have updated the documentation accordingly

Summary by CodeRabbit

• Style

  • Improved code formatting and readability across server and test files, including multi-line argument lists and clearer handling of unused parameters.
  • Enhanced code clarity by marking unused function parameters with underscores and refining loop constructs in tests.
  • Minor whitespace and formatting cleanups for consistency.

• Tests

  • Updated test code formatting for better readability without changing test logic or behavior.

[coderabbitai]

Walkthrough

The changes across the files consist of stylistic refactoring and formatting improvements. These include reformatting function calls and signatures, marking unused parameters with underscores, and adjusting whitespace. No logic, control flow, or error handling was altered. All modifications are cosmetic, aiming to enhance code clarity and consistency without affecting behavior.

Changes

Files	Change Summary
server/server.go	Reformatted error formatting and function calls to multi-line style; replaced unused parameter names with underscores; minor whitespace cleanup; no logic changes.
server/server_race_test.go	Renamed unused function parameter to underscore and reformatted function signature to multi-line style; no logic changes.
server/server_test.go	Reformatted function calls and assertions to multi-line style; replaced unused parameters with underscores; updated loop style; no logic changes.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 28c9cc3 and efd8fa7.

📒 Files selected for processing (3)

• server/server.go (9 hunks)
• server/server_race_test.go (1 hunks)
• server/server_test.go (21 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

server/server.go (2)

mcp/types.go (6)

• Params (154-154)
• InitializeRequest (389-398)
• PingRequest (478-480)
• EmptyResult (355-355)
• Named (1011-1013)
• Cursor (108-108)

server/errors.go (1)

• ErrResourceNotFound (11-11)

🔇 Additional comments (31)

server/server_race_test.go (1)

129-134: LGTM: Renamed unused parameter to underscore.

The name parameter was renamed to _ to explicitly indicate it's unused in the function. This is a good practice in Go and prevents gopls warnings.

server/server_test.go (21)

263-274: LGTM: Improved readability with consistent multi-line formatting.

Reformatting the AddTool function calls to use multi-line arguments improves readability and code organization.

---

510-515: LGTM: Consistent multi-line formatting.

Changed notification handler registration to use consistent multi-line formatting.

---

616-617: LGTM: Using idiomatic Go range syntax.

Changed from for i := 0; i < 5; i++ to for i := range 5, which is a more idiomatic Go approach when iterating over a fixed count.

---

629-635: LGTM: Improved assertion readability.

Reformatted assertion to use multi-line style for better readability.

---

682-692: LGTM: Consistent function call formatting.

Reformatted function call to multi-line style for better readability and consistency.

---

794-798: LGTM: Consistent function call formatting.

Reformatted function call to multi-line style for better readability and consistency.

---

911-916: LGTM: Consistent function call formatting.

Reformatted function call to multi-line style for better readability and consistency.

---

1376-1387: LGTM: Improved readability with consistent multi-line formatting.

Reformatted hook registration function call to use multi-line arguments.

---

1389-1393: LGTM: Consistent multi-line formatting.

Reformatted hook registration function call to use multi-line arguments.

---

1401-1409: LGTM: Consistent multi-line formatting.

Reformatted hook registration function call to use multi-line arguments.

---

1415-1419: LGTM: Consistent multi-line formatting.

Reformatted hook registration function call to use multi-line arguments.

---

1493-1498: LGTM: Improved assertion readability.

Reformatted assertion to use multi-line style for better readability.

---

1500-1505: LGTM: Improved assertion readability.

Reformatted assertion to use multi-line style for better readability.

---

1513-1518: LGTM: Improved assertion readability.

Reformatted assertion to use multi-line style for better readability.

---

1523-1534: LGTM: Improved assertion readability.

Reformatted assertions to use multi-line style for better readability.

---

1636-1640: LGTM: Improved assertion readability.

Reformatted assertion to use multi-line style for better readability.

---

1682-1685: LGTM: Improved method chain readability.

Reformatted method chaining to use multi-line style for better readability.

---

1698-1699: LGTM: Using idiomatic Go range syntax in benchmark.

Changed to use range syntax in the benchmark function.

---

1707-1708: LGTM: Using idiomatic Go range syntax in benchmark.

Changed to use range syntax in the benchmark function.

---

1727-1731: LGTM: Improved assertion readability.

Reformatted assertion to use multi-line style for better readability.

---

1744-1748: LGTM: Improved assertion readability.

Reformatted assertion to use multi-line style for better readability.

server/server.go (9)

223-228: LGTM: Improved error message readability.

Reformatted error message construction to use multi-line style for better readability.

---

493-496: LGTM: Marked unused parameters with underscores.

Unused parameters in handleInitialize function are now properly marked with underscores to explicitly indicate they're not used in the function body. This helps silence Go language server warnings.

---

549-552: LGTM: Marked unused parameters with underscores.

All parameters in the handlePing function are now marked with underscores to explicitly indicate they're not used. This follows Go best practices for unused parameters.

---

599-603: LGTM: Marked unused parameter with underscore.

The context parameter in listByPagination function is now marked with an underscore to explicitly indicate it's not used.

---

651-656: LGTM: Improved function call readability.

Reformatted the listByPagination function call to use multi-line style for better readability.

---

687-692: LGTM: Improved function call readability.

Reformatted the listByPagination function call to use multi-line style for better readability.

---

764-769: LGTM: Improved error message readability.

Reformatted error message construction to use multi-line style for better readability.

---

793-798: LGTM: Improved function call readability.

Reformatted the listByPagination function call to use multi-line style for better readability.

---

911-916: LGTM: Improved function call readability.

Reformatted the listByPagination function call to use multi-line style for better readability.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.