Skip to content

Conversation

@joaquimg
Copy link
Collaborator

@joaquimg joaquimg commented Jan 4, 2022

No description provided.

@joaquimg
Copy link
Collaborator Author

joaquimg commented Jan 4, 2022

This was easier than expected, MatrixOfConstraints and struct_of_constraints_by_set_types are great.

Weird fails are:

test_model_UpperBoundAlreadySet
test_model_LowerBoundAlreadySet

Probably due jump-dev/MathOptInterface.jl#1665

test_model_ScalarFunctionConstantNotZero

Possibly UniversalFallback stuff

cc @odow

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #90 (73d5fea) into master (f0d2d91) will increase coverage by 3.10%.
The diff coverage is 89.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   82.02%   85.12%   +3.10%     
==========================================
  Files          11       11              
  Lines        1391     1217     -174     
==========================================
- Hits         1141     1036     -105     
+ Misses        250      181      -69     
Impacted Files Coverage Δ
src/equilibration.jl 0.00% <0.00%> (ø)
src/util.jl 77.77% <ø> (-22.23%) ⬇️
src/pdhg.jl 81.01% <70.96%> (+1.36%) ⬆️
src/MOI_wrapper.jl 92.01% <96.58%> (+9.21%) ⬆️
src/eigsolver.jl 90.81% <100.00%> (+0.30%) ⬆️
src/options.jl 100.00% <100.00%> (ø)
src/printing.jl 92.85% <100.00%> (+11.90%) ⬆️
src/prox_operators.jl 100.00% <100.00%> (ø)
src/residuals.jl 100.00% <100.00%> (ø)
src/scaling.jl 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d2d91...73d5fea. Read the comment docs.

@odow
Copy link
Contributor

odow commented Jan 5, 2022

test_model_UpperBoundAlreadySet
test_model_LowerBoundAlreadySet
test_model_ScalarFunctionConstantNotZero

Just exclude these ones for now. The AlreadySet ones will be fixed in an upcoming release of MOI. The ScalarFunctionConstantNotZero is optional.

@joaquimg
Copy link
Collaborator Author

joaquimg commented Jan 5, 2022

Version >= 1.7 requires a fix in MOI: jump-dev/MathOptInterface.jl#1711

@joaquimg joaquimg merged commit c379eb9 into master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants