Skip to content

refactor: prefer explicit cache over circular reference #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marioevz merged 1 commit into from
Dec 2, 2025
Merged

refactor: prefer explicit cache over circular reference #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/testing/src/execution_testing/fixtures/pre_alloc_groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,13 +193,14 @@ class GroupPreAlloc(Alloc):
string or JSON format depending on the last request.
"""

_pre_alloc_group: "PreAllocGroup" = PrivateAttr(init=False)
_cached_state_root: Hash | None = PrivateAttr(None)
_model_dump_cache: ModelDumpCache | None = PrivateAttr(None)
_cache_miss_count: int = PrivateAttr(0)

def state_root(self) -> Hash:
"""On pre-alloc groups, which are normally very big, we always cache."""
return self._pre_alloc_group.genesis.state_root
if self._cached_state_root is not None:
return self._cached_state_root
return super().state_root()

def model_dump( # type: ignore[override]
self, mode: Literal["json", "python"], **kwargs: Any
Expand All @@ -219,7 +220,6 @@ def model_dump( # type: ignore[override]
):
return self._model_dump_cache.data

self._cache_miss_count += 1
data = super().model_dump(mode=mode, **kwargs)
self._model_dump_cache = ModelDumpCache(
model_dump_mode=mode,
Expand All @@ -239,7 +239,6 @@ def model_dump_json(self, **kwargs: Any) -> str:
):
return self._model_dump_cache.data

self._cache_miss_count += 1
data = super().model_dump_json(**kwargs)
self._model_dump_cache = ModelDumpCache(
model_dump_mode="json",
Expand Down Expand Up @@ -267,10 +266,10 @@ class PreAllocGroup(PreAllocGroupBuilder):

def model_post_init(self, __context: Any) -> None:
"""
Model post init method to set GroupPreAlloc reference.
Model post init method to cache the state root in GroupPreAlloc.
"""
super().model_post_init(__context)
self.pre._pre_alloc_group = self
self.pre._cached_state_root = self.genesis.state_root

@classmethod
def from_file(cls, file: Path) -> Self:
Expand Down