explicitly add yaml as a dep#1420
Merged
mscolnick merged 1 commit intomarimo-team:mainfrom May 20, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @dmadisetti - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Contributor
|
|
mscolnick
approved these changes
May 20, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.6.1-dev8 |
mscolnick
pushed a commit
that referenced
this pull request
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Cool template!
📝 Summary
Add yaml dep, since it is not default. Tests passed because pyyaml is a dep of pytest.
🛠️ Additional Information
Added pyyaml as a dep to nixpkgs. Will submit for review whenever the next version bump is later this week or whatever
NixOS/nixpkgs#313178
📋 Checklist Before Submitting
🧩 Related Issues
Fixes #1418
📜 Who Can Review?
@mscolnick