Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circular_progress_bar crash #641

Closed
sielnet opened this issue May 6, 2023 · 4 comments · Fixed by #658
Closed

circular_progress_bar crash #641

sielnet opened this issue May 6, 2023 · 4 comments · Fixed by #658
Labels
bug Something isn't working

Comments

@sielnet
Copy link

sielnet commented May 6, 2023

Reproduction steps

Install latest Pods version from flathub.
Start Pods.
Pods crashes.

flatpak run com.github.marhkb.Pods

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/view/component/circular_progress_bar.rs:140:18
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Environment

  • Pods version: 1.1.1 from flathub
@sielnet sielnet added the bug Something isn't working label May 6, 2023
@marhkb
Copy link
Owner

marhkb commented May 6, 2023

Thanks for reporting. This crashes on coloring the circular progress bar.

Are your using a custom theme / stylesheet?

@marhkb marhkb added the needs info More information is needed to resolve the issue label May 7, 2023
@sielnet
Copy link
Author

sielnet commented May 11, 2023

I updated to version xxx from flatpak.

Still the same error:

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', 
src/view/component/circular_progress_bar.rs:140:18

Are your using a custom theme / stylesheet?
Yes but it is a official theme. I am running fedora 38. I choose "prefer dark theme" for the gtk4 apps.
And I set env=GTK_THEME=Adwaita-dark for gtk3 apps.
Adwaita is not a custom theme. MAybe it does not work with adwaita dark?

gsettings set org.gnome.desktop.interface color-scheme prefer-dark
flatpak install org.gtk.Gtk3theme.Adwaita-dark
flatpak install flathub org.kde.KStyle.Adwaita
sudo flatpak override --env=GTK_THEME=Adwaita-dark
and i set Adwaita-dark in gnome-tweak

@sielnet
Copy link
Author

sielnet commented May 11, 2023

I was able to "fix" it by sudo flatpak override --unset-env=GTK_THEME

@marhkb
Copy link
Owner

marhkb commented May 11, 2023

Thanks for the feeedback. I can reproduce it with sudo flatpak override --env=GTK_THEME=Adwaita-dark.

I just had a look at https://gitlab.gnome.org/World/Authenticator/-/blob/master/src/widgets/progress_icon.rs#L52 and think I will use the same approach to fix it.

@marhkb marhkb removed the needs info More information is needed to resolve the issue label May 11, 2023
marhkb added a commit that referenced this issue May 11, 2023
The user could set a custom theme lacking the requested colors. Although
this will look broken and completely out of place, we still don't want
the application to crash because it couldn't find a color.

Fixes #641
marhkb added a commit that referenced this issue May 11, 2023
The user could set a custom theme lacking the requested colors. Although
this will look broken and completely out of place, we still don't want
the application to crash because it couldn't find a color.

Fixes #641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants