-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'RNSkiaModule.h' file not found with <angled> include; use "quotes" instead #25
Comments
Same problem with version 2.1.0. This is strange because user @relaxxxpls encounters the same problem here but seems to get it work by installing the latest version... |
Can anyone of you please provide a reproduction repository for that issue? Much appreciated, thanks! 😊 |
Here you are. |
@hannojg any luck with the repo I provided? |
Hey, just checked your reproduction. The issue seems to arise due to the usage of |
|
I also use Firebase, so use_framework is needed unfortunately. |
@hannojg is there any fix for use_frameworks? |
I'm having the same issue and also use Firebase |
@hannojg I've tried to fix it, but it looks like a linking problem because Firebase requires linkage static. Do you think we can use angled symbols for both situations? |
Is using angle brackets fixing the issue for you? When I tested it fixed this particular build error but then caused a bunch of others. Is using react-native-skia with Firebase / use_frameworks possible? |
@hannojg I'll test again and let you know |
Shopify/react-native-skia#652 (comment) Can anyone try this? Seems already in RNSkia since 183 i believe |
It is actually the only workaround at the moment if you want to install react native skia, I've already provided the repository to try here #25 (comment) |
@hannojg Yes the workaround that @idrakimuhamad mentionned is the one that allows to install skia without errors. The podfile I gave you already includes this workaround |
Yeah i think we don't actually need the workaround as it's already being part of the pod-spec now(?) |
@idrakimuhamad I've tried without it and it doesn't work but maybe I did something wrong. Please make a new project and install react native skia and if it works then provide a repository for us thanks |
Chill. What I meant is that, because i'm using firebase and also Skia in my codebase. I do not have issue when installing Skia nor when building the app, so I did not use the workaround. I only get this error when building the app once skottie are being added. |
i mean... this error is here for a good moment now, did they abandon the project or what xdd |
@hannojg 🥺 |
Also seeing this. Would be great with a fix asap! |
Can someone help with any workaround for this issue for now? |
Is there any progress on this issue? |
Should be fixed in version https://github.com/margelo/react-native-skottie/releases/tag/v2.1.1 |
Thanks. I'm able to build the app as of v2.1.1, though I'm getting some other crashes related to my lottie file. I will open another ticket. |
Thank you very much @hannojg (building ok with [email protected] + @shopify/[email protected] and [email protected] - I mentionned this because updating skia was very important also) |
simple patch for ios native module
The text was updated successfully, but these errors were encountered: