Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: conversion to nitro modules #404

Merged
merged 47 commits into from
Aug 15, 2024
Merged

Conversation

boorad
Copy link
Collaborator

@boorad boorad commented Aug 9, 2024

Refactor entire codebase to use new architecture / bridgeless / fabric / nitro-modules.

Add benchmarking facility, and add benchmarks for each function ported over to nitro-modules.

Start by porting random module first, get it working fully, fix tests, etc.

Subsequent PRs in the main branch and *-beta.* releases will port the rest of the modules to nitro. Status, as always, will be represented in implementation-coverage.md.

@boorad
Copy link
Collaborator Author

boorad commented Aug 9, 2024

We need to add & fix tests as we convert to nitro modules, as well as add benchmarks.

tests test details benchmarks benchmark details
Simulator Screenshot - iPhone 15 Pro - 2024-08-09 at 16 37 40 Simulator Screenshot - iPhone 15 Pro - 2024-08-09 at 16 37 43 Simulator Screenshot - iPhone 15 Pro - 2024-08-09 at 15 54 32 Simulator Screenshot - iPhone 15 Pro - 2024-08-09 at 15 54 19

@boorad boorad marked this pull request as draft August 10, 2024 01:49
@mrousavy
Copy link
Member

🔥🔥🔥

@boorad boorad marked this pull request as ready for review August 15, 2024 15:46
@boorad boorad merged commit e1c779f into margelo:main Aug 15, 2024
6 checks passed
@boorad boorad deleted the refactor/nitro branch August 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants