-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes #199
Minor fixes #199
Conversation
@ospfranco, do you know when we can expect a new release with all the changes? It would be very helpful to not have to patch the package anymore and to have less warnings. Thanks for your work by the way! |
Only @mrousavy has release permissions on the package I think |
@mrousavy, thank you for contributing to this package! Do you have any ideas when all these changes can be released? I think that would be helpful for a lot of people! |
please give me some time to polish this, no need to comment on every change |
@mrousavy do you have time to review and release this? |
Hey - yes I do, but I'm on vacation right now and it was just weekend. |
${{ runner.os }}-gradle- | ||
- name: Run Gradle Build for android/ | ||
run: cd android && ./gradlew assembleDebug --build-cache && cd .. | ||
# - name: Restore Gradle cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it's commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup-java@v3 already has a cache logic integrated, see line 33
@@ -108,20 +99,11 @@ android { | |||
} | |||
|
|||
buildTypes { | |||
debug { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied the latest build.gradle from builder.bob, I guess none of this options are no longer needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this we won't be able to debug the library with android studio debugger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add it back and I will merge the pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -142,7 +124,22 @@ repositories { | |||
|
|||
dependencies { | |||
//noinspection GradleDynamicVersion | |||
implementation 'com.facebook.react:react-android:+' | |||
implementation "com.facebook.react:react-native:+" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will that break older rn versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the opposite it will break versions above 0.71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On older versions react-native:+ is kept. On versions above 0.71 is automatically replaced by react-android:+. This is done automatically by the react plugin
Thanks @ospfranco for the pr! |
Debug config has been added back. Ready to merge @Szymon20000 |
Thanks @ospfranco!!! |
babel-plugin-module-resolver
binaryLikeToArrayBuffer
where the default encoding would try to create a Buffer withbuffer
encoding.(input as any).buffer
toArrayBuffer.isView(input)
onbinaryLikeToArrayBuffer