379 reduce force unwraps, use if/guard let and isEmpty

Keyboards/KeyboardsBase/Colors/ColorVariables.swift

@@ -30,10 +30,10 @@ var keyPressedColor = UIColor(.keyPressed)
 
 var commandKeyColor = UIColor(.commandKey)
 var commandBarColor = UIColor(.commandBar)
-var commandBarBorderColor = UIColor(.commandBarBorder).cgColor
+var commandBarBorderColor = UIColor(resource: .commandBarBorder).cgColor
 
 var keyboardBgColor = UIColor(.keyboardBackground)
-var keyShadowColor = UIColor(.keyShadow).cgColor
+var keyShadowColor = UIColor(resource: .keyShadow).cgColor
 
 // annotate colors.
 var annotateRed = UIColor(.annotateRed)

Keyboards/KeyboardsBase/InterfaceVariables.swift

@@ -202,8 +202,7 @@ func setKeyboard() {
 func setKeyboardLayout() {
   if commandState == .translate {
     setENKeyboardLayout()
-  } else {
-    let setLayoutFxn: () -> Void = keyboardLayoutDict[controllerLanguage]!
+  } else if let setLayoutFxn = keyboardLayoutDict[controllerLanguage] {
     setLayoutFxn()
   }
 

Keyboards/KeyboardsBase/KeyAltChars.swift

@@ -329,50 +329,51 @@ func alternateKeysPathRight(
 ///   - sender: the long press of the given key.
 func genAlternatesView(key: UIButton) {
   // Get the frame in respect to the superview.
-  let frame = (key.superview?.convert(key.frame, to: nil))!
-  let width = key.frame.width
-
-  // Derive which button was pressed and get its alternates.
-  let char = key.layer.value(forKey: "original") as? String ?? ""
-  alternateKeys = keyAlternatesDict[char] ?? [""]
-
-  // Add the original key given its location on the keyboard.
-  if keysWithAlternatesLeft.contains(char) {
-    alternateKeys.insert(char, at: 0)
-  } else if keysWithAlternatesRight.contains(char) {
-    alternateKeys.append(char)
-  }
-  let numAlternates = CGFloat(alternateKeys.count)
-
-  if keysWithAlternatesLeft.contains(char) {
-    alternatesViewX = frame.origin.x - 4.0
-    alternatesShapeLayer.path = alternateKeysPathLeft(
-      startX: frame.origin.x, startY: frame.origin.y,
-      keyWidth: width, keyHeight: key.frame.height, numAlternates: numAlternates
-    ).cgPath
-  } else if keysWithAlternatesRight.contains(char) {
-    alternatesViewX = frame.origin.x + width - CGFloat(width * numAlternates + (3.0 * numAlternates) + 2.0)
-    alternatesShapeLayer.path = alternateKeysPathRight(
-      startX: frame.origin.x, startY: frame.origin.y,
-      keyWidth: width, keyHeight: key.frame.height, numAlternates: numAlternates
-    ).cgPath
-  }
+  if let frame = key.superview?.convert(key.frame, to: nil) {
+    let width = key.frame.width
+
+    // Derive which button was pressed and get its alternates.
+    let char = key.layer.value(forKey: "original") as? String ?? ""
+    alternateKeys = keyAlternatesDict[char] ?? [""]
+
+    // Add the original key given its location on the keyboard.
+    if keysWithAlternatesLeft.contains(char) {
+      alternateKeys.insert(char, at: 0)
+    } else if keysWithAlternatesRight.contains(char) {
+      alternateKeys.append(char)
+    }
+    let numAlternates = CGFloat(alternateKeys.count)
+
+    if keysWithAlternatesLeft.contains(char) {
+      alternatesViewX = frame.origin.x - 4.0
+      alternatesShapeLayer.path = alternateKeysPathLeft(
+        startX: frame.origin.x, startY: frame.origin.y,
+        keyWidth: width, keyHeight: key.frame.height, numAlternates: numAlternates
+      ).cgPath
+    } else if keysWithAlternatesRight.contains(char) {
+      alternatesViewX = frame.origin.x + width - CGFloat(width * numAlternates + (3.0 * numAlternates) + 2.0)
+      alternatesShapeLayer.path = alternateKeysPathRight(
+        startX: frame.origin.x, startY: frame.origin.y,
+        keyWidth: width, keyHeight: key.frame.height, numAlternates: numAlternates
+      ).cgPath
+    }
 
-  if numAlternates > 0 {
-    alternatesViewWidth = CGFloat(width * numAlternates + (3.0 * numAlternates) + 8.0)
-  }
+    if numAlternates > 0 {
+      alternatesViewWidth = CGFloat(width * numAlternates + (3.0 * numAlternates) + 8.0)
+    }
 
-  alternatesViewY = frame.origin.y - key.frame.height * 1.135
-  alternatesBtnHeight = key.frame.height * 0.9
-  alternatesKeyView = UIView(
-    frame: CGRect(
-      x: alternatesViewX,
-      y: alternatesViewY,
-      width: alternatesViewWidth,
-      height: key.frame.height * 1.2
+    alternatesViewY = frame.origin.y - key.frame.height * 1.135
+    alternatesBtnHeight = key.frame.height * 0.9
+    alternatesKeyView = UIView(
+      frame: CGRect(
+        x: alternatesViewX,
+        y: alternatesViewY,
+        width: alternatesViewWidth,
+        height: key.frame.height * 1.2
+      )
     )
-  )
 
-  alternatesKeyView.tag = 1001
-  key.backgroundColor = keyColor
+    alternatesKeyView.tag = 1001
+    key.backgroundColor = keyColor
+  }
 }

Keyboards/KeyboardsBase/KeyAnimation.swift

@@ -270,53 +270,54 @@ func centerKeyPopPath(
 ///   - displayChar: the character to display on the pop up.
 func getKeyPopPath(key: UIButton, layer: CAShapeLayer, char: String, displayChar: String) {
   // Get the frame in respect to the superview.
-  let frame = (key.superview?.convert(key.frame, to: nil))!
-  var labelVertPosition = frame.origin.y - key.frame.height / 1.75
-  // non-capital characters should be higher for portrait phone views.
-  if displayChar == char, DeviceType.isPhone, !isLandscapeView,
-     !["0", "1", "2", "3", "4", "5", "6", "7", "8", "9"].contains(char)
-  {
-    labelVertPosition = frame.origin.y - key.frame.height / 1.6
-  } else if DeviceType.isPad,
-            isLandscapeView
-  {
-    labelVertPosition = frame.origin.y - key.frame.height / 2
-  }
-
-  if centralKeyChars.contains(char) {
-    layer.path = centerKeyPopPath(
-      startX: frame.origin.x, startY: frame.origin.y,
-      keyWidth: key.frame.width, keyHeight: key.frame.height, char: char
-    ).cgPath
-    keyPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.5, y: labelVertPosition)
-    keyHoldPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.5, y: labelVertPosition)
-  } else if leftKeyChars.contains(char) {
-    layer.path = leftKeyPopPath(
-      startX: frame.origin.x, startY: frame.origin.y,
-      keyWidth: key.frame.width, keyHeight: key.frame.height, char: char
-    ).cgPath
-    keyPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.85, y: labelVertPosition)
-    keyHoldPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.85, y: labelVertPosition)
-    if DeviceType.isPad || (DeviceType.isPhone && isLandscapeView) {
-      keyPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.65, y: labelVertPosition)
-      keyHoldPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.65, y: labelVertPosition)
+  if let frame = key.superview?.convert(key.frame, to: nil) {
+    var labelVertPosition = frame.origin.y - key.frame.height / 1.75
+    // non-capital characters should be higher for portrait phone views.
+    if displayChar == char, DeviceType.isPhone, !isLandscapeView,
+       !["0", "1", "2", "3", "4", "5", "6", "7", "8", "9"].contains(char)
+    {
+      labelVertPosition = frame.origin.y - key.frame.height / 1.6
+    } else if DeviceType.isPad,
+              isLandscapeView
+    {
+      labelVertPosition = frame.origin.y - key.frame.height / 2
     }
-  } else if rightKeyChars.contains(char) {
-    layer.path = rightKeyPopPath(
-      startX: frame.origin.x, startY: frame.origin.y,
-      keyWidth: key.frame.width, keyHeight: key.frame.height, char: char
-    ).cgPath
-    keyPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.15, y: labelVertPosition)
-    keyHoldPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.15, y: labelVertPosition)
-    if DeviceType.isPad || (DeviceType.isPhone && isLandscapeView) {
-      keyPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.35, y: labelVertPosition)
-      keyHoldPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.35, y: labelVertPosition)
+
+    if centralKeyChars.contains(char) {
+      layer.path = centerKeyPopPath(
+        startX: frame.origin.x, startY: frame.origin.y,
+        keyWidth: key.frame.width, keyHeight: key.frame.height, char: char
+      ).cgPath
+      keyPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.5, y: labelVertPosition)
+      keyHoldPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.5, y: labelVertPosition)
+    } else if leftKeyChars.contains(char) {
+      layer.path = leftKeyPopPath(
+        startX: frame.origin.x, startY: frame.origin.y,
+        keyWidth: key.frame.width, keyHeight: key.frame.height, char: char
+      ).cgPath
+      keyPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.85, y: labelVertPosition)
+      keyHoldPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.85, y: labelVertPosition)
+      if DeviceType.isPad || (DeviceType.isPhone && isLandscapeView) {
+        keyPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.65, y: labelVertPosition)
+        keyHoldPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.65, y: labelVertPosition)
+      }
+    } else if rightKeyChars.contains(char) {
+      layer.path = rightKeyPopPath(
+        startX: frame.origin.x, startY: frame.origin.y,
+        keyWidth: key.frame.width, keyHeight: key.frame.height, char: char
+      ).cgPath
+      keyPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.15, y: labelVertPosition)
+      keyHoldPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.15, y: labelVertPosition)
+      if DeviceType.isPad || (DeviceType.isPhone && isLandscapeView) {
+        keyPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.35, y: labelVertPosition)
+        keyHoldPopChar.center = CGPoint(x: frame.origin.x + key.frame.width * 0.35, y: labelVertPosition)
+      }
     }
-  }
 
-  layer.strokeColor = keyShadowColor
-  layer.fillColor = keyColor.cgColor
-  layer.lineWidth = 1.0
+    layer.strokeColor = keyShadowColor
+    layer.fillColor = keyColor.cgColor
+    layer.lineWidth = 1.0
+  }
 }
 
 /// Sizes the character displayed on a key pop for iPhones.

Keyboards/KeyboardsBase/KeyboardViewController.swift

@@ -1855,12 +1855,6 @@ class KeyboardViewController: UIInputViewController {
       }
     }
 
-    if userDefaults.bool(forKey: "svAccentCharacters") {
-      disableAccentCharacters = true
-    } else {
-      disableAccentCharacters = false
-    }
-
     // Actions to be done only on initial loads.
     if isFirstKeyboardLoad {
       shiftButtonState = .shift

Keyboards/KeyboardsBase/ScribeFunctionality/CommandBar.swift

@@ -47,7 +47,12 @@ class CommandBar: UILabel {
 
   /// Allows the class to be accessed from Keyboard.xib.
   class func instanceFromNib() -> UIView {
-    return UINib(nibName: "Keyboard", bundle: nil).instantiate(withOwner: nil, options: nil)[0] as! UIView
+    let nibContents = UINib(nibName: "Keyboard", bundle: nil).instantiate(withOwner: nil, options: nil)
+    if let view = nibContents.first as? UIView {
+      return view
+    } else {
+      fatalError("Failed to instantiate view from nib.")
+    }
   }
 
   var shadow: UIButton!

Keyboards/KeyboardsBase/ScribeFunctionality/Plural.swift

@@ -50,7 +50,7 @@ func queryPlural(commandBar: UILabel) {
   let args = [noun]
   let outputCols = ["plural"]
   wordToReturn = queryDBRow(query: query, outputCols: outputCols, args: args)[0]
-  
+
   guard !wordToReturn.isEmpty else {
     commandState = .invalid
     return

Keyboards/KeyboardsBase/ScribeFunctionality/ScribeKey.swift

@@ -31,7 +31,10 @@ class ScribeKey: UIButton {
 
   /// Allows the class to be accessed from Keyboard.xib.
   class func instanceFromNib() -> UIView {
-    return UINib(nibName: "Keyboard", bundle: nil).instantiate(withOwner: nil, options: nil)[0] as! UIView
+    guard let nibContents = UINib(nibName: "Keyboard", bundle: nil).instantiate(withOwner: nil, options: nil).first as? UIView else {
+      fatalError("Failed to instantiate view from nib.")
+    }
+    return nibContents
   }
 
   /// Converts the Scribe key to an escape key to return to the base keyboard view.

Scribe/AboutTab/AboutViewController.swift

@@ -17,12 +17,11 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-import UIKit
 import MessageUI
 import StoreKit
+import UIKit
 
 final class AboutViewController: BaseTableViewController {
-
   override var dataSet: [ParentTableCellModel] {
     AboutTableData.aboutTableData
   }
@@ -39,10 +38,10 @@ final class AboutViewController: BaseTableViewController {
 // MARK: UITableViewDataSource
 
 extension AboutViewController {
-
   override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
-    let cell = tableView.dequeueReusableCell(withIdentifier: AboutTableViewCell.reuseIdentifier, for: indexPath) as! AboutTableViewCell
-
+    guard let cell = tableView.dequeueReusableCell(withIdentifier: AboutTableViewCell.reuseIdentifier, for: indexPath) as? AboutTableViewCell else {
+      fatalError("Failed to dequeue AboutTableViewCell.")
+    }
     cell.configureCell(for: dataSet[indexPath.section].section[indexPath.row])
 
     return cell
@@ -52,7 +51,6 @@ extension AboutViewController {
 // MARK: UITableViewDelegate
 
 extension AboutViewController {
-
   override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
     let tableSection = dataSet[indexPath.section]
     let section = tableSection.section[indexPath.row]
@@ -100,11 +98,10 @@ extension AboutViewController {
 
     case .appLang: break
     case .none: break
-    case .specificLang(_): break
+    case .specificLang: break
     case .externalLink: break
     }
 
-
     if let selectedIndexPath = tableView.indexPathForSelectedRow {
       tableView.deselectRow(at: selectedIndexPath, animated: false)
     }
@@ -159,15 +156,14 @@ extension AboutViewController {
     guard let encodedURLString = encodedString, let url = URL(string: encodedURLString) else { return }
 
     let shareSheetVC = UIActivityViewController(activityItems: [url], applicationActivities: nil)
-    
+
     present(shareSheetVC, animated: true, completion: nil)
   }
 }
 
 // MARK: - MFMailComposeViewControllerDelegate
 
 extension AboutViewController: MFMailComposeViewControllerDelegate {
-
   func mailComposeController(_ controller: MFMailComposeViewController, didFinishWith _: MFMailComposeResult, error _: Error?) {
     controller.dismiss(animated: true, completion: nil)
   }

Scribe/AppExtensions.swift

@@ -31,20 +31,29 @@ extension UIImage {
     if let image = UIImage(named: imageString) {
       return image
     } else {
-      return UIImage(systemName: imageString) ?? UIImage(systemName: "info.circle")!
+      if let image = UIImage(systemName: imageString) {
+        return image
+      } else {
+        guard let infoCircleSymbol = UIImage(systemName: "info.circle") else {
+          fatalError("Failed to create info circle symbol image.")
+        }
+        return infoCircleSymbol
+      }
     }
   }
 }
 
 extension UIView {
   var parentViewController: UIViewController? {
-    var parentResponder: UIResponder? = self
-    while parentResponder != nil {
-      parentResponder = parentResponder!.next
-      if parentResponder is UIViewController {
-        return parentResponder as? UIViewController
+    var currentResponder: UIResponder? = self
+
+    while let responder = currentResponder {
+      if let viewController = responder as? UIViewController {
+        return viewController
       }
+      currentResponder = responder.next
     }
+
     return nil
   }
 }

Scribe/AppUISymbols.swift

@@ -32,7 +32,9 @@ func getSettingsSymbol(fontSize: CGFloat) -> UIImage {
       settingsSymbolConfig = UIImage.SymbolConfiguration(pointSize: fontSize * 0.15, weight: .medium, scale: .medium)
     }
   }
-  let settingsSymbol = UIImage(systemName: "gearshape", withConfiguration: settingsSymbolConfig)!
+  guard let settingsSymbol = UIImage(systemName: "gearshape", withConfiguration: settingsSymbolConfig) else {
+    fatalError("Failed to create settings symbol image.")
+  }
 
   return settingsSymbol
 }
@@ -50,7 +52,9 @@ func getPrivacySymbol(fontSize: CGFloat) -> UIImage {
       privacySymbolConfig = UIImage.SymbolConfiguration(pointSize: fontSize * 0.2, weight: .medium, scale: .medium)
     }
   }
-  let privacySymbol = UIImage(systemName: "lock.shield", withConfiguration: privacySymbolConfig)!
+  guard let privacySymbol = UIImage(systemName: "lock.shield", withConfiguration: privacySymbolConfig) else {
+    fatalError("Failed to create privacy symbol image.")
+  }
 
   return privacySymbol
 }