Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19, same thing as tkrajina/gpxpy#178 (comment).
This also adds an emoji to one of the test files, which before the fix fails on the CI on Windows (but not macOS or Linux): https://github.com/hugovk/strava_py/actions/runs/2987678688
After the fix, all pass.
Also use a "context manager" to open the file, instead of:
Do this:
A context manager takes care of closing file handles in case of errors, and is equivalent to
More info: https://towardsdatascience.com/why-you-should-use-context-managers-in-python-4f10fe231206