fix: add missing local declarations in cmd_transition to prevent cross-contamination #967
Conversation
…s-contamination
The session_id, worktree, branch, log_file, and pr_url variables in
cmd_transition() were not declared as local. When the pulse cycle calls
cmd_transition() in a loop for multiple tasks, these variables leaked
between calls via the shell's global scope. A call with --branch or
--pr-url would set the global, and subsequent calls without those flags
would still see the stale value via ${branch:-} / ${pr_url:-} checks,
overwriting unrelated tasks' DB rows.
This was the root cause of all PR cross-contamination (6 historical
duplicates, plus ongoing backlog-19 contamination where PR #962 was
linked to 5 unrelated tasks).
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Tue Feb 10 18:25:17 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
1 participant
Summary
localdeclarations forsession_id,worktree,branch,log_file, andpr_urlincmd_transition()caseblock withoutlocal, causing them to leak into the shell's global scopecmd_transition()in a loop for multiple tasks, stale values from a previous call would be picked up by${branch:-}/${pr_url:-}checks and written to unrelated tasks' DB rowsRoot Cause
This was the root cause of all PR cross-contamination we've been tracking:
feature/t236.1tofeature/t236.5(the last dispatched task)Why t232 didn't catch it
The centralized
link_pr_to_task()(t232) validates PR ownership when called explicitly. Butcmd_transition()has its own--pr-urlflag that writes directly to the DB — and the stale global variable caused it to silently pass a wrong PR URL without going through validation.One-line fix
Verification
localkeyword ensures variables are scoped to the function and reset to empty on each call--branch/--pr-urlwill correctly see empty values and skip the DB update