fix(release): include aidevops.sh in version updates#78
Conversation
The aidevops.sh CLI script was not being updated during releases, causing npm installs to have outdated version strings. Changes: - Add aidevops.sh to update_version_in_files() - Add aidevops.sh to validate_version_consistency() - Add aidevops.sh to git add in commit_version_changes() - Update aidevops.sh to current version 2.54.0
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughExtended version management script to include aidevops.sh in version validation and update workflows. Version header in aidevops.sh bumped from 2.13.0 to 2.54.0. No functional behavioral changes detected—this is a version synchronization update across the DevOps framework. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (3)**/*.sh📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/.agent/scripts/version-manager.sh📄 CodeRabbit inference engine (AGENTS.md)
Files:
.agent/scripts/*.sh⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (6)📓 Common learnings📚 Learning: 2025-12-22T01:24:53.937ZApplied to files:
📚 Learning: 2025-12-22T01:25:03.138ZApplied to files:
📚 Learning: 2025-12-22T01:24:53.937ZApplied to files:
📚 Learning: 2026-01-06T15:57:56.027ZApplied to files:
📚 Learning: 2026-01-06T15:57:56.027ZApplied to files:
🧬 Code graph analysis (1).agent/scripts/version-manager.sh (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the issue of aidevops.sh not being included in the version update process. The changes are logical and consistently applied across the validation, update, and commit functions in version-manager.sh. I've added a couple of suggestions to refactor the newly added logic, which is duplicated in several places, into helper functions. This would improve the maintainability of the script. Overall, this is a good fix.
| if [[ -f "$REPO_ROOT/aidevops.sh" ]]; then | ||
| if grep -q "# Version: $expected_version" "$REPO_ROOT/aidevops.sh"; then | ||
| print_success "aidevops.sh: $expected_version ✓" | ||
| else | ||
| print_error "aidevops.sh does not contain version $expected_version" | ||
| errors=$((errors + 1)) | ||
| fi | ||
| fi |
There was a problem hiding this comment.
This block correctly validates the version in aidevops.sh. However, it's very similar to the other validation blocks in this function (e.g., the one for marketplace.json that follows). To improve maintainability and reduce code duplication, consider refactoring this logic into a helper function.
For example, you could create a function like this:
_validate_file_version() {
local file_path="$1"
local grep_pattern="$2"
local file_desc="$3"
local expected_version="$4"
if [[ -f "$file_path" ]]; then
if grep -q "$grep_pattern" "$file_path"; then
print_success "$file_desc: $expected_version ✓"
else
print_error "$file_desc does not contain version $expected_version"
errors=$((errors + 1))
fi
fi
}Then you could call it for each file:
_validate_file_version "$REPO_ROOT/aidevops.sh" "# Version: $expected_version" "aidevops.sh" "$expected_version"
_validate_file_version "$REPO_ROOT/.claude-plugin/marketplace.json" '"version": "$expected_version"' "Claude Code plugin" "$expected_version"This would make the validate_version_consistency function much cleaner and easier to extend in the future.
| if [[ -f "$REPO_ROOT/aidevops.sh" ]]; then | ||
| sed -i '' "s/# Version: .*/# Version: $new_version/" "$REPO_ROOT/aidevops.sh" | ||
| print_success "Updated aidevops.sh" | ||
| fi |
There was a problem hiding this comment.
This block correctly updates the version in aidevops.sh. Similar to the validation function, this logic is repeated for several files. To make the code more DRY (Don't Repeat Yourself), you could abstract this into a helper function.
For example:
_update_file_version() {
local file_path="$1"
local sed_expr="$2"
local file_desc="$3"
if [[ -f "$file_path" ]]; then
sed -i '' "$sed_expr" "$file_path"
print_success "Updated $file_desc"
fi
}And then call it like this:
_update_file_version "$REPO_ROOT/aidevops.sh" "s/# Version: .*/# Version: $new_version/" "aidevops.sh"This would simplify the update_version_in_files function and make it easier to add more files to the versioning process in the future.
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Wed Jan 14 01:25:09 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
🤖 Augment PR SummarySummary: Ensures the release/version bump automation updates the root Changes: Adds 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
|
|
||
| # Check aidevops.sh CLI | ||
| if [[ -f "$REPO_ROOT/aidevops.sh" ]]; then | ||
| if grep -q "# Version: $expected_version" "$REPO_ROOT/aidevops.sh"; then |
There was a problem hiding this comment.
grep -q treats . as “any character”, so version strings like 2.54.0 can match unintended text; consider grep -Fq for a fixed-string match (also applies to the other version consistency checks).
🤖 Was this useful? React with 👍 or 👎
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
The
aidevops.shCLI script was not being updated during releases, causing npm installs to have outdated version strings (e.g., v2.13.0 instead of v2.54.0).Changes
aidevops.shtoupdate_version_in_files()aidevops.shtovalidate_version_consistency()aidevops.shtogit addincommit_version_changes()aidevops.shto current version 2.54.0Testing
After merge, the next release will automatically update
aidevops.shversion string.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.