Skip to content

fix: supervisor claim/unclaim now matches indented subtasks in TODO.md #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcusquinn merged 1 commit into from
Feb 9, 2026
Merged

fix: supervisor claim/unclaim now matches indented subtasks in TODO.md #760

marcusquinn merged 1 commit into from
Feb 9, 2026

Conversation

@marcusquinn
Copy link
Owner

@marcusquinn marcusquinn commented Feb 9, 2026 •
edited by coderabbitai bot
Loading

Summary

  • Fix supervisor's inability to dispatch subtasks (e.g., t132.2, t168.2) from TODO.md
  • Change grep patterns from ^- \[ to ^[[:space:]]*- \[ in claim/unclaim/lookup functions

Problem

The supervisor's claim, unclaim, and task lookup functions used ^- \[ \] regex which only matched top-level tasks. Subtasks in TODO.md are indented:

- [ ] t132 Cross-Provider Model Routing  (top-level - matched)
  - [ ] t132.2 Provider/model registry   (subtask - NOT matched)

This caused all subtask dispatches to fail with "Task tXXX.X not found as open in TODO.md".

Fix

Changed 7 grep patterns to use ^[[:space:]]*- \[ which matches both:

  • - [ ] t132 ... (top-level, zero indent)
  • - [ ] t132.2 ... (subtask, 2+ space indent)

Functions Fixed

  • cmd_claim() — task existence check + line number lookup
  • cmd_unclaim() — line number lookup
  • check_task_claimed() — task line lookup
  • get_task_gh_issue() — task line lookup
  • Task description lookup in add command

Note: mark_task_complete() already handled indented subtasks correctly.

Testing

  • ShellCheck: no new violations
  • Bash syntax: verified OK

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced task management to correctly handle indented tasks in documentation files, improving accuracy of task identification, assignment, and claiming operations.
    • Improved task processing to robustly support varied indentation formats, ensuring consistent behavior regardless of how tasks or subtasks are formatted.

@marcusquinn
fix: supervisor claim/unclaim now matches indented subtasks in TODO.md
bfd096c 
The claim, unclaim, and task lookup functions used '^- \[ \]' which only
matched top-level tasks. Subtasks (indented with spaces like '  - [ ] t132.2')
were invisible to the supervisor, causing dispatch failures for all subtask IDs.

Changed grep patterns from '^- \[' to '^[[:space:]]*- \[' in:
- cmd_claim() task existence check and line number lookup
- cmd_unclaim() line number lookup
- check_task_claimed() task line lookup
- get_task_gh_issue() task line lookup
- add task description lookup from TODO.md

The completion function (mark_task_complete) already handled indented subtasks.
@gemini-code-assist
Copy link

gemini-code-assist bot commented Feb 9, 2026

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Updated regex patterns in .agents/scripts/supervisor-helper.sh to handle leading whitespace in TODO.md entries. Added explicit whitespace character classes across five task-related functions to robustly match indented subtask entries.

Changes

Cohort / File(s) Summary
TODO.md Pattern Matching Refinement
.agents/scripts/supervisor-helper.sh		 Updated regex patterns in cmd_add, find_task_issue_number, get_task_assignee, cmd_claim, and cmd_unclaim to use ^[[:space:]]*- instead of ^- for matching indented TODO list items and subtasks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

Regex whispers through the code,
Indentation marks the hidden road,
Patterns bloom with whitespace grace,
✨ Finding tasks in every place. 🎯

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/supervisor-subtask-claim

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 50 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Mon Feb 9 04:58:22 UTC 2026: Code review monitoring started
Mon Feb 9 04:58:22 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 50

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 50
  • VULNERABILITIES: 0

Generated on: Mon Feb 9 04:58:25 UTC 2026

Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@marcusquinn marcusquinn merged commit 1654064 into main Feb 9, 2026
10 of 11 checks passed
@marcusquinn marcusquinn mentioned this pull request Feb 10, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@marcusquinn