Skip to content

fix: remove auth gate from onboarding launch#702

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/revert-onboarding-auth-check
Feb 9, 2026
Merged

fix: remove auth gate from onboarding launch#702
marcusquinn merged 1 commit intomainfrom
bugfix/revert-onboarding-auth-check

Conversation

@marcusquinn
Copy link
Owner

@marcusquinn marcusquinn commented Feb 9, 2026

Summary

  • Removes the auth.json check that was blocking the onboarding launch when no auth was configured
  • OpenCode handles authentication interactively — it doesn't need pre-auth to launch
  • Restores the original auto-launch behavior: always offer to launch, let OpenCode handle auth
  • Model detection still works as a nice-to-have (picks Claude/Gemini if auth exists)

What was wrong

PR #698 added an auth check that showed "run opencode auth login" instead of launching OpenCode when no auth.json existed. This was incorrect — OpenCode prompts for auth on first run.

Net result (PR #698 + this PR)

The good parts of #698 are preserved:

  • Commands generation decoupled from find_opencode_config guard (commands work without opencode.json)
  • update_opencode_config runs after setup_opencode_cli in interactive path

Only the incorrect auth gate is removed.

Summary by CodeRabbit

  • Chores
    • Simplified onboarding workflow to consistently present setup options to users.
    • Implemented automatic AI model selection during initialization based on available authentication providers.

…itself

The auth check added in PR #698 incorrectly blocked the onboarding launch
when no auth.json existed. OpenCode handles authentication interactively
and doesn't need pre-auth. Restore the original auto-launch behavior.
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

The setup.sh script now unconditionally offers OpenCode onboarding and dynamically selects a model based on detected authentication providers in auth.json. The conditional gating that checked for existing authentication is removed, replaced with inline provider detection that populates an optional --model parameter for the onboarding command.

Changes

Cohort / File(s) Summary
OpenCode Onboarding Logic Simplification
setup.sh
Removed conditional authentication check before onboarding prompt. Added inline auth provider detection from auth.json to dynamically select model (anthropic/claude-sonnet-4-5 or google/gemini-2.5-flash). Constructs onboarding command with optional --model parameter based on available provider. Net reduction of 18 lines.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

Scripts refactored, logic lean—
Auth providers now foreseen,
Models picked with grace,
Onboarding finds its place,
Zero debt maintained supreme! 🚀

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/revert-onboarding-auth-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 45 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Mon Feb 9 01:30:34 UTC 2026: Code review monitoring started
Mon Feb 9 01:30:35 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 45

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 45
  • VULNERABILITIES: 0

Generated on: Mon Feb 9 01:30:37 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

@marcusquinn marcusquinn merged commit d0568d3 into main Feb 9, 2026
10 of 11 checks passed
@marcusquinn marcusquinn deleted the bugfix/revert-onboarding-auth-check branch February 9, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments