Skip to content

t4946: eliminate redundant detect_package_manager call in check_requirements #4949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-solovyev merged 1 commit into from
Mar 15, 2026
Merged

t4946: eliminate redundant detect_package_manager call in check_requirements #4949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions setup-modules/core.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,10 @@ check_requirements() {
local missing_deps=()
local missing_packages=()

# Detect package manager once for both package-name resolution and installation
local pkg_manager
pkg_manager=$(detect_package_manager)

# Check for required commands
# Format: command-name package-name (same when identical)
if ! command -v jq >/dev/null 2>&1; then
Expand All @@ -443,10 +447,8 @@ check_requirements() {
fi
if ! command -v sqlite3 >/dev/null 2>&1; then
missing_deps+=("sqlite3")
# Package name varies: sqlite3 on Debian/Ubuntu/apt, sqlite on brew/Fedora/Arch/Alpine
local pkg_mgr
pkg_mgr=$(detect_package_manager)
case "$pkg_mgr" in
# Package name varies: sqlite3 on Debian/Ubuntu (apt), sqlite on Homebrew/Fedora/Arch/Alpine
case "$pkg_manager" in
apt) missing_packages+=("sqlite3") ;;
*) missing_packages+=("sqlite") ;;
esac
Expand All @@ -455,9 +457,6 @@ check_requirements() {
if [[ ${#missing_deps[@]} -gt 0 ]]; then
print_warning "Missing required dependencies: ${missing_deps[*]}"

local pkg_manager
pkg_manager=$(detect_package_manager)

if [[ "$pkg_manager" == "unknown" ]]; then
print_error "Could not detect package manager"
echo ""
Expand Down
Loading