Skip to content

fix: add sqlite3 to setup.sh required dependencies #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-solovyev merged 2 commits into from
Mar 15, 2026
Merged

fix: add sqlite3 to setup.sh required dependencies #4935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8c6f53
fix: add sqlite3 to setup.sh required dependencies
superdav42 Mar 15, 2026
13f05ab
fix: use canonical brew formula name 'sqlite' instead of alias 'sqlite3'
alex-solovyev Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions setup-modules/core.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,16 @@ check_requirements() {
missing_deps+=("rg")
missing_packages+=("ripgrep")
fi
if ! command -v sqlite3 >/dev/null 2>&1; then
missing_deps+=("sqlite3")
# Package name varies: sqlite3 on Debian/Ubuntu/apt, sqlite on brew/Fedora/Arch/Alpine
local pkg_mgr
pkg_mgr=$(detect_package_manager)
Comment on lines +447 to +448
Copy link

@gemini-code-assist gemini-code-assist bot Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This call to detect_package_manager is redundant, as the same function is called again on line 459 if any dependencies are missing. To improve efficiency, you could call detect_package_manager once at the beginning of the check_requirements function and store the result in a variable for reuse.

References
  1. Avoid redundant pre-checks or function calls that perform checks, especially when a helper function handles the logic internally. This prevents logic duplication and improves efficiency.

case "$pkg_mgr" in
apt) missing_packages+=("sqlite3") ;;
*) missing_packages+=("sqlite") ;;
esac
fi

if [[ ${#missing_deps[@]} -gt 0 ]]; then
print_warning "Missing required dependencies: ${missing_deps[*]}"
Expand Down
Loading