Skip to content

t1491: fix Bash 3.2 bad substitution in config_get indirect expansion #4931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 1 commit into from
Mar 15, 2026
Merged

t1491: fix Bash 3.2 bad substitution in config_get indirect expansion #4931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .agents/scripts/config-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,9 @@ config_get() {
local env_var
env_var=$(_config_env_map "$dotpath")
if [[ -n "$env_var" ]]; then
local env_val="${!env_var:-}"
# Use eval for Bash 3.2 compat — ${!var:-} causes "bad substitution" on 3.2
local env_val=""
eval "env_val=\${$env_var:-}"
if [[ -n "$env_val" ]]; then
echo "$env_val"
return 0
Expand Down Expand Up @@ -524,7 +526,8 @@ cmd_list() {
local env_var
env_var=$(_config_env_map "$dotpath")
if [[ -n "$env_var" ]]; then
env_val="${!env_var:-}"
# Use eval for Bash 3.2 compat — ${!var:-} causes "bad substitution" on 3.2
eval "env_val=\${$env_var:-}"
fi

# Determine source and effective value
Expand Down Expand Up @@ -725,11 +728,12 @@ HEADER
echo "[OK] Set ${dotpath}=${value}" >&2

# Show if an env var would override this
local env_val
local env_val=""
local env_var
env_var=$(_config_env_map "$dotpath")
if [[ -n "$env_var" ]]; then
env_val="${!env_var:-}"
# Use eval for Bash 3.2 compat — ${!var:-} causes "bad substitution" on 3.2
eval "env_val=\${$env_var:-}"
if [[ -n "$env_val" ]]; then
echo "[WARN] Environment variable ${env_var}=${env_val} will override this setting" >&2
fi
Expand Down
Loading