Skip to content

refactor(quality): replace blanket ShellCheck disables with targeted per-file disables (t135.2) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 2 commits into from
Feb 7, 2026
Merged

refactor(quality): replace blanket ShellCheck disables with targeted per-file disables (t135.2) #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e47301
refactor(quality): replace blanket ShellCheck disables with targeted …
marcusquinn Feb 7, 2026
8a29ca9
fix(ci): guard wait in monitor-code-review.sh for set -e compatibility
marcusquinn Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/scripts/101domains-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2034,SC2155
set -euo pipefail

# 101domains Registrar Helper Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/_archive/add-missing-returns.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2030,SC2031,SC2129,SC2317

# Add Missing Return Statements
# Systematically add return 0 to functions missing explicit returns
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/_archive/fix-auth-headers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2317

# Fix Authorization Header String Literals
# Replace repeated "Authorization: Bearer" patterns with constants
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/_archive/fix-common-strings.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2016,SC2030,SC2031,SC2317

# Common String Literals Fix Script
# Fix the most common repeated string literals for SonarCloud S1192 compliance
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/_archive/fix-content-type.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2016,SC2317

# Fix Content-Type String Literals
# Replace repeated "Content-Type: application/json" with constants
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/_archive/fix-error-messages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2317

# Fix Common Error Message String Literals
# Replace repeated error message patterns with constants
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/_archive/fix-misplaced-returns.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2016

# Script to fix misplaced return statements in mainwp-helper.sh
# These were introduced by the earlier mass fix script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/_archive/fix-remaining-literals.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2016,SC2030,SC2031,SC2317

# Fix Remaining String Literals
# Target specific high-impact string literal patterns
Expand Down
1 change: 0 additions & 1 deletion .agents/scripts/_archive/fix-return-statements.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153

# Script to add return statements to functions that need them
# Based on SonarCloud S7682 issues
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/_archive/fix-sc2155-simple.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2016,SC2034,SC2317

# Fix SC2155 Issues - Simple Approach
# Fix "declare and assign separately" issues
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/_archive/fix-shellcheck-critical.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2317

# Fix Critical ShellCheck Issues
# Address SC2155 (declare and assign separately) and SC2181 (exit code checking)
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/_archive/fix-string-literals.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2001,SC2030,SC2031,SC2154,SC2317

# String Literals Fix Script
# Identify and fix repeated string literals for SonarCloud S1192 compliance
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/agent-browser-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091
set -euo pipefail

# Agent Browser Helper - Headless Browser Automation CLI for AI Agents
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/agno-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091
set -euo pipefail

# Agno + Agent-UI Setup Script for AI DevOps Framework
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/auto-version-bump.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2181
set -euo pipefail

# Auto Version Bump Script for AI DevOps Framework
Expand Down
1 change: 0 additions & 1 deletion .agents/scripts/closte-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
set -euo pipefail

# Closte Helper - Placeholder for future implementation
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/cloudron-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2129,SC2317
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

SC2317 (unreachable code) is masking real bugs — don't suppress it, fix the root cause.

SC2317 fires because check_status and list_apps have misplaced return 0 statements that make subsequent code unreachable. Suppressing this warning hides functional bugs rather than silencing a false positive. See comments below on lines 175–188 and 150–153.

🤖 Prompt for AI Agents 
In @.agents/scripts/cloudron-helper.sh at line 2, The shellcheck suppression is
hiding real unreachable-code bugs: the functions check_status and list_apps
contain misplaced early "return 0" statements that make later logic unreachable
and trigger SC2317; remove or relocate those premature returns so the full
function logic executes and place a single, final return at the intended
function exit, then remove SC2317 from the "# shellcheck disable=..." list;
update check_status and list_apps to return consistent exit codes only at the
end and run shellcheck to verify SC2317 no longer appears.

set -euo pipefail

# Cloudron Helper Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/codacy-cli-chunked.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2015,SC2034,SC2086,SC2155,SC2317
set -euo pipefail

# Codacy CLI v2 Chunked Analysis Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/codacy-cli.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2015,SC2181,SC2317
set -euo pipefail

# Codacy CLI v2 Integration Script
Expand Down
1 change: 0 additions & 1 deletion .agents/scripts/code-audit-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
set -euo pipefail

# Code Audit Helper - Placeholder for future implementation
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/coderabbit-cli.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2317
set -euo pipefail

# CodeRabbit CLI Integration Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/coderabbit-pro-analysis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091
set -euo pipefail

# CodeRabbit Pro Analysis Trigger Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/comprehensive-quality-fix.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2016
set -euo pipefail

# Comprehensive script to fix remaining SonarCloud issues
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/coolify-cli-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091

# Coolify CLI Helper Script
# Comprehensive Coolify self-hosted deployment and management using Coolify CLI
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/coolify-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2129
set -euo pipefail

# Coolify Helper Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/crawl4ai-examples.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2119,SC2120,SC2155
set -euo pipefail

# Crawl4AI Examples Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/crawl4ai-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2086,SC2154
set -euo pipefail

# Crawl4AI Helper Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/dev-browser-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2162

# Dev-Browser Helper - Stateful Browser Automation
# Part of AI DevOps Framework
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/dns-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2153,SC2155
set -euo pipefail

# DNS Management Helper Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/dspy-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091
set -euo pipefail

# DSPy Helper Script for AI DevOps Framework
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/dspyground-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2154,SC2317
set -euo pipefail

# DSPyGround Helper Script for AI DevOps Framework
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/eeat-score-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2034

# E-E-A-T Score Helper Script
# Content quality scoring using Google's E-E-A-T framework
Expand Down
1 change: 0 additions & 1 deletion .agents/scripts/efficient-return-fix.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
set -euo pipefail

# Efficient script to add return statements to functions that need them
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/find-missing-returns.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091
set -euo pipefail

# Find Functions Missing Return Statements
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/git-platforms-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2034,SC2154,SC2155,SC2162,SC2181,SC2317
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# First, check if the file exists and read the relevant sections
if [ -f ".agents/scripts/git-platforms-helper.sh" ]; then
  echo "=== Lines 1-10 of git-platforms-helper.sh ==="
  head -10 ".agents/scripts/git-platforms-helper.sh" | cat -n
  echo ""
  echo "=== File size ==="
  wc -l ".agents/scripts/git-platforms-helper.sh"
else
  echo "File not found"
fi

Repository: marcusquinn/aidevops

Length of output: 582

🏁 Script executed:

#!/bin/bash
# Search for SC2181 violations - checking $? instead of direct command evaluation
echo "=== SC2181 pattern: checking \$? in conditionals ==="
rg '\$\?' .agents/scripts/git-platforms-helper.sh -n | head -20

echo ""
echo "=== SC2317 pattern: code after return ==="
rg -A2 'return [0-9]' .agents/scripts/git-platforms-helper.sh -n | grep -E '^\s+[a-z]|return' | head -30

Repository: marcusquinn/aidevops

Length of output: 827

🏁 Script executed:

#!/bin/bash
# Check for the disable directive on line 2
echo "=== Line 2 content (the disable directive) ==="
sed -n '2p' .agents/scripts/git-platforms-helper.sh

echo ""
echo "=== Count disabled rules ==="
sed -n '2p' .agents/scripts/git-platforms-helper.sh | grep -oP 'SC\d+' | wc -l

Repository: marcusquinn/aidevops

Length of output: 212

🏁 Script executed:

#!/bin/bash
# Look for duplicate constants mentioned in review
echo "=== Checking for duplicate HELP_SHOW_MESSAGE ==="
rg 'HELP_SHOW_MESSAGE=' .agents/scripts/git-platforms-helper.sh -n

echo ""
echo "=== Checking for duplicate USAGE_COMMAND_OPTIONS ==="
rg 'USAGE_COMMAND_OPTIONS=' .agents/scripts/git-platforms-helper.sh -n

Repository: marcusquinn/aidevops

Length of output: 392

🏁 Script executed:

#!/bin/bash
# Check main() function structure around lines 519-540
echo "=== Lines 519-540 (main function area) ==="
sed -n '519,540p' .agents/scripts/git-platforms-helper.sh | cat -n

Repository: marcusquinn/aidevops

Length of output: 1048

Remove ShellCheck disables and fix the underlying issues instead of suppressing them—the script has critical execution bugs.

The targeted disable approach violates the zero-violations requirement. Verification confirms these suppressions mask real, fixable bugs:

  • SC2181 (6 violations): Lines 194, 214, 245, 265, 295, 406 use if [[ $? -eq 0 ]]—fix with direct command evaluation (if command; then)
  • Duplicate constants: Lines 14 and 22 define HELP_SHOW_MESSAGE identically; lines 15 and 23 define USAGE_COMMAND_OPTIONS identically—remove duplicates
  • Broken main() function (lines 520–540): Contains triple-duplicated variable assignments followed by contradictory overwrites. Lines 521–523 self-reference undefined variables (local account_name="$account_name"), causing empty/undefined assignments. Lines 533–536 then overwrite with different undefined variables. This pattern prevents the script from functioning correctly.

These issues are not ShellCheck false positives—they are runtime correctness bugs that must be fixed to meet the zero-technical-debt standard.

🤖 Prompt for AI Agents 
In @.agents/scripts/git-platforms-helper.sh at line 2, Remove the ShellCheck
disables by fixing the root issues: replace all occurrences of post-command exit
checks like "if [[ $? -eq 0 ]]" with direct command tests (e.g., "if <command>;
then") to satisfy SC2181; remove the duplicate constant definitions for
HELP_SHOW_MESSAGE and USAGE_COMMAND_OPTIONS so each is defined only once; and
correct the broken main() function by declaring and assigning its local
variables exactly once from the intended sources (e.g., function parameters,
parsed options, or explicit env vars) instead of self-referencing undefined
names (remove lines like local account_name="$account_name" and the later
contradictory overwrites), ensuring variables are populated in a single, clear
assignment flow inside main().

set -euo pipefail

# Git Platforms Helper Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/gitea-cli-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091

# Gitea CLI Helper Script
# Comprehensive Gitea management using tea (Gitea CLI) and API
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/github-cli-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2034

# GitHub CLI Helper Script
# Comprehensive GitHub management using GitHub CLI (gh)
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/gitlab-cli-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2034

# GitLab CLI Helper Script
# Comprehensive GitLab management using GitLab CLI (glab)
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/hetzner-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2029,SC2129
set -euo pipefail

# Hetzner Helper Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/hostinger-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091
set -euo pipefail

# Hostinger Helper Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/keyword-research-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2034,SC2086,SC2155,SC2162

# Keyword Research Helper Script
# Comprehensive keyword research with SERP weakness detection and opportunity scoring
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/linter-manager.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091
set -euo pipefail

# Linter Manager - CodeFactor-Inspired Multi-Language Linter Installation
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/linters-local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2086
# =============================================================================
# Local Linters - Fast Offline Quality Checks
# =============================================================================
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/localhost-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2317
set -euo pipefail

# Localhost Development Helper Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/markdown-formatter.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2317
set -euo pipefail

# Markdown Formatter Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/markdown-lint-fix.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2317
set -euo pipefail

# Markdown Lint Fix Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/mass-fix-returns.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091
set -euo pipefail

# Mass fix script to add return statements to all functions that need them
Expand Down
8 changes: 4 additions & 4 deletions .agents/scripts/monitor-code-review.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2155,SC2317
set -euo pipefail

# Code Review Monitoring and Auto-Fix Script (Enhanced Version)
Expand Down Expand Up @@ -116,9 +116,9 @@ run_codacy_analysis() {
done
echo "" # New line

# Check exit status
wait $pid
local status=$?
# Check exit status (|| true prevents set -e from killing script on non-zero)
local status=0
wait $pid || status=$?

if [[ $status -eq 0 ]]; then
print_success "Codacy analysis completed with auto-fixes"
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/pagespeed-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2154

# 🚀 PageSpeed Insights & Lighthouse Helper Script
# Comprehensive website performance auditing and optimization guidance
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/pandoc-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2317
set -euo pipefail

# Pandoc Document Conversion Helper for AI DevOps Framework
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/pre-commit-hook.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091
# Pre-commit hook for multi-platform quality validation
# Install with: cp .agents/scripts/pre-commit-hook.sh .git/hooks/pre-commit && chmod +x .git/hooks/pre-commit

Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/privacy-filter-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2155

# Privacy Filter for Public PRs
# Mandatory filter before contributing to public repositories
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/qlty-cli.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2317
set -euo pipefail

# Qlty CLI Integration Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/quality-cli-manager.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091,SC2317
set -euo pipefail

# Quality CLI Manager Script
Expand Down
2 changes: 1 addition & 1 deletion .agents/scripts/quality-feedback-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
# shellcheck disable=SC1091
# quality-feedback-helper.sh - Retrieve code quality feedback via GitHub API
# Consolidates feedback from Codacy, CodeRabbit, SonarCloud, CodeFactor, etc.
#
Expand Down
Loading
Loading