Skip to content

fix(issue3174): sanitize flag file reads in cmd_start and cmd_stop #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 1 commit into from
Mar 14, 2026
Merged

fix(issue3174): sanitize flag file reads in cmd_start and cmd_stop #4876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/scripts/pulse-session-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@

if is_session_active; then
local started_at
started_at=$(grep '^started_at=' "$SESSION_FLAG" | cut -d= -f2)
started_at=$(grep '^started_at=' "$SESSION_FLAG" | cut -d= -f2 | tr -cd '[:alnum:]T:Z.+-')
print_warning "Pulse session already active (started: ${started_at:-unknown})"
echo ""
echo " To restart: aidevops pulse stop && aidevops pulse start"
Expand Down Expand Up @@ -251,7 +251,7 @@

local started_at=""
if is_session_active; then
started_at=$(grep '^started_at=' "$SESSION_FLAG" | cut -d= -f2)
started_at=$(grep '^started_at=' "$SESSION_FLAG" | cut -d= -f2 | tr -cd '[:alnum:]T:Z.+-')
fi

# Create stop flag — this overrides all consent layers immediately
Expand Down Expand Up @@ -416,7 +416,7 @@
fi
if [[ "$has_session_flag" == "true" ]]; then
local started_at started_by
started_at=$(grep '^started_at=' "$SESSION_FLAG" | cut -d= -f2 | tr -cd '[:alnum:]T:Z.+-')

Check warning on line 419 in .agents/scripts/pulse-session-helper.sh

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Define a constant instead of using the literal '[:alnum:]T:Z.+-' 4 times. 


See more on https://sonarcloud.io/project/issues?id=marcusquinn_aidevops&issues=AZztU3-O93q8aLTr1dho&open=AZztU3-O93q8aLTr1dho&pullRequest=4876
started_by=$(grep '^started_by=' "$SESSION_FLAG" | cut -d= -f2 | tr -cd '[:alnum:]._-')
echo -e " Session flag: ${GREEN}active${NC} (${started_at:-unknown} by ${started_by:-unknown})"
else
Expand Down
Loading