fix(portability): replace sed -i with portable sed_inplace wrapper (t145) #479
Conversation
…145) Replace all non-portable sed -i usage across 17 active scripts with the shared sed_inplace() wrapper from shared-constants.sh. BSD sed requires 'sed -i ""' while GNU sed requires 'sed -i' (no argument), causing silent failures on Linux/CI. Changes: - Add sed_append_after() to shared-constants.sh for portable line insertion - Remove 6 duplicate local sed_inplace definitions, source shared-constants.sh - Replace bare sed -i (GNU-only) in comprehensive-quality-fix.sh, mass-fix-returns.sh - Replace sed -i.tmp/.bak with sed_inplace (eliminates leftover temp files) - Add inline sed_inplace to aidevops.sh (standalone CLI, can't depend on .agents/) - Fix supervisor-helper.sh append operations to use sed_append_after - Make webhosting-helper.sh user instruction platform-aware - Skip _archive/ scripts and setup.sh (already uses BSD-then-GNU fallback) Closes #440
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
WalkthroughCentralizes cross-platform sed utilities by consolidating duplicated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sat Feb 7 20:32:41 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.agents/scripts/sonarcloud-autofix.sh (1)
136-136:⚠️ Potential issue | 🔴 CriticalBug:
$_arg2is likely undefined; should be$2.
$_arg2is not a standard variable or parameter — this should be"$2"to match the positional argument from themaincase dispatch. This is a pre-existing bug but will cause thefixcommand to always operate on an empty/wrong path.Proposed fix
- apply_sonarcloud_fixes "$_arg2" + apply_sonarcloud_fixes "$2"
🤖 Fix all issues with AI agents
In @.agents/scripts/agent-test-helper.sh:
- Line 53: The script soft-sources shared-constants.sh but later unconditionally
calls sed_inplace in cmd_create, which leads to a cryptic "command not found"
under set -euo pipefail if the file is missing; to fix, after the existing
source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true add an explicit
guard that verifies required symbols (e.g., test for the sed_inplace
function/variable and any other utilities used by cmd_create) and exit with a
clear error message if missing, or change the source to be mandatory (remove the
"|| true") for scripts that cannot run without shared-constants.sh; update
cmd_create references to rely on that guard so failures surface with a
descriptive log rather than an opaque shell error.
In @.agents/scripts/comprehensive-quality-fix.sh:
- Around line 66-84: The sed_append_after calls use hardcoded line numbers and
are executed top-down which shifts subsequent targets; update each case block
(e.g., the "closte-helper.sh", "cloudron-helper.sh", "coolify-helper.sh",
"dns-helper.sh" blocks) to perform insertions bottom-up by ordering
sed_append_after calls from highest to lowest line number or by collecting
target lines into an array and sorting it descending before calling
sed_append_after (ensuring the function name sed_append_after remains unchanged
and only the call order/loop logic is changed).
- Around line 7-9: The script silently ignores failures sourcing
shared-constants.sh leaving helpers like sed_inplace and sed_append_after
undefined; change the sourcing to explicitly check the file and abort (or at
least warn) if it cannot be loaded: ensure SCRIPT_DIR is computed, verify
"$SCRIPT_DIR/shared-constants.sh" exists and is readable, source it without
redirecting errors (or capture and handle failure), then confirm required
symbols (e.g., sed_inplace, sed_append_after) are available and call process
exit with a clear error message if they are missing so subsequent commands don't
fail with "command not found."
In @.agents/scripts/privacy-filter-helper.sh:
- Line 33: The script silently ignores failures when sourcing
shared-constants.sh, which can leave the sed_inplace function undefined and
cause apply_redactions() to fail later; remove the "|| true" fallback so
sourcing errors surface, or add an explicit guard after sourcing that checks for
the sed_inplace symbol (e.g., test if the function/command sed_inplace exists)
and print a clear error and exit if missing; ensure this guard references
SCRIPT_DIR and shared-constants.sh so maintainers can locate where the
dependency is loaded and avoid the opaque "command not found" failure under set
-euo pipefail.
In @.agents/scripts/supervisor-helper.sh:
- Line 81: The script silently ignores failure when sourcing shared-constants.sh
(which defines sed_inplace and sed_append_after) because of "2>/dev/null ||
true", causing later "command not found" errors; remove the silent suppression
and add an explicit warning if the source fails (or move the source below the
log_warn definition and use log_warn), e.g., try sourcing shared-constants.sh
without redirecting stderr and on failure emit a clear message referencing
shared-constants.sh and the missing functions (sed_inplace, sed_append_after)
and either exit or continue with a documented fallback; ensure references to
log_warn (or a temporary echo >&2 fallback placed before log_warn is defined)
are used so the warning is visible.
In @.agents/scripts/version-manager.sh:
- Around line 22-24: The script sources shared-constants.sh to obtain
sed_inplace but does not handle a failed source; update_version_in_files and
auto_mark_tasks_complete call sed_inplace and will break the release if
undefined. Fix by adding a fail-fast check immediately after the source (verify
sed_inplace is defined and executable) and abort with a clear error if not, or
alternatively implement a minimal inline fallback for sed_inplace before any
calls (declare a portable sed_inplace function used by update_version_in_files
and auto_mark_tasks_complete). Reference symbols: shared-constants.sh,
SCRIPT_DIR, sed_inplace, update_version_in_files, auto_mark_tasks_complete.
🧹 Nitpick comments (1)
.agents/scripts/watercrawl-helper.sh (1)
39-41:SCRIPT_DIRis defined twice — lines 40 and 56.The first definition (line 40) is used for sourcing
shared-constants.sh. Then line 56 redefines it identically and line 57 makes itreadonly. This is harmless but redundant. Consider removing the duplicate:Proposed cleanup
# Source shared constants (provides sed_inplace and other utilities) SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true # Colors for output readonly GREEN='\033[0;32m' ... # Constants -SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit -readonly SCRIPT_DIR +readonly SCRIPT_DIRAlso applies to: 56-57
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit | ||
| # shellcheck disable=SC2034 | ||
| readonly SCRIPT_DIR | ||
| source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true |
There was a problem hiding this comment.
Soft-sourcing shared-constants.sh but hard-depending on sed_inplace at line 869.
The 2>/dev/null || true pattern means sourcing silently succeeds even if the file is missing. However, cmd_create() at line 869 calls sed_inplace, which will fail with an opaque "command not found" error under set -euo pipefail. This applies to several other scripts in this PR that follow the same pattern (quality-fix.sh, auto-version-bump.sh, coderabbit-cli.sh, readme-helper.sh, security-helper.sh).
Consider adding a guard after sourcing:
Proposed fix
source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true
+if ! declare -f sed_inplace >/dev/null 2>&1; then
+ echo "ERROR: shared-constants.sh failed to load (sed_inplace unavailable)" >&2
+ exit 1
+fiAlternatively, keep the source mandatory (remove || true) for scripts that cannot function without the shared utilities. As per coding guidelines, automation scripts should focus on reliability, robustness, and clear logging/feedback.
🤖 Prompt for AI Agents
In @.agents/scripts/agent-test-helper.sh at line 53, The script soft-sources
shared-constants.sh but later unconditionally calls sed_inplace in cmd_create,
which leads to a cryptic "command not found" under set -euo pipefail if the file
is missing; to fix, after the existing source "$SCRIPT_DIR/shared-constants.sh"
2>/dev/null || true add an explicit guard that verifies required symbols (e.g.,
test for the sed_inplace function/variable and any other utilities used by
cmd_create) and exit with a clear error message if missing, or change the source
to be mandatory (remove the "|| true") for scripts that cannot run without
shared-constants.sh; update cmd_create references to rely on that guard so
failures surface with a descriptive log rather than an opaque shell error.
| # Source shared constants (provides sed_inplace and other utilities) | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit | ||
| source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true |
There was a problem hiding this comment.
Silent failure if shared-constants.sh fails to load leaves sed_inplace/sed_append_after undefined.
The 2>/dev/null || true suppresses all errors, so if the source fails, the script continues but every subsequent sed_inplace / sed_append_after call will error out with "command not found." Consider adding a guard or at least a warning:
Proposed fix
# Source shared constants (provides sed_inplace and other utilities)
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit
-source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true
+source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || {
+ echo "⚠️ shared-constants.sh not found; sed_inplace/sed_append_after unavailable" >&2
+ exit 1
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Source shared constants (provides sed_inplace and other utilities) | |
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit | |
| source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true | |
| # Source shared constants (provides sed_inplace and other utilities) | |
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit | |
| source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || { | |
| echo "⚠️ shared-constants.sh not found; sed_inplace/sed_append_after unavailable" >&2 | |
| exit 1 | |
| } |
🤖 Prompt for AI Agents
In @.agents/scripts/comprehensive-quality-fix.sh around lines 7 - 9, The script
silently ignores failures sourcing shared-constants.sh leaving helpers like
sed_inplace and sed_append_after undefined; change the sourcing to explicitly
check the file and abort (or at least warn) if it cannot be loaded: ensure
SCRIPT_DIR is computed, verify "$SCRIPT_DIR/shared-constants.sh" exists and is
readable, source it without redirecting errors (or capture and handle failure),
then confirm required symbols (e.g., sed_inplace, sed_append_after) are
available and call process exit with a clear error message if they are missing
so subsequent commands don't fail with "command not found."
| "closte-helper.sh") | ||
| # Lines 134, 249 | ||
| sed -i '133a\ return 0' "$file" | ||
| sed -i '248a\ return 0' "$file" | ||
| sed_append_after 133 ' return 0' "$file" | ||
| sed_append_after 248 ' return 0' "$file" | ||
| ;; | ||
| "cloudron-helper.sh") | ||
| # Lines 74, 202 | ||
| sed -i '73a\ return 0' "$file" | ||
| sed -i '201a\ return 0' "$file" | ||
| sed_append_after 73 ' return 0' "$file" | ||
| sed_append_after 201 ' return 0' "$file" | ||
| ;; | ||
| "coolify-helper.sh") | ||
| # Line 236 | ||
| sed -i '235a\ return 0' "$file" | ||
| sed_append_after 235 ' return 0' "$file" | ||
| ;; | ||
| "dns-helper.sh") | ||
| # Lines 95, 259 | ||
| sed -i '94a\ return 0' "$file" | ||
| sed -i '258a\ return 0' "$file" | ||
| sed_append_after 94 ' return 0' "$file" | ||
| sed_append_after 258 ' return 0' "$file" | ||
| ;; |
There was a problem hiding this comment.
Sequential sed_append_after calls with hardcoded line numbers produce off-by-one errors after the first insertion.
Each sed_append_after inserts a line, shifting all subsequent line numbers by +1. The second call in each case block still uses the original line number, so it targets the wrong line.
For example in closte-helper.sh (comment says "Lines 134, 249"):
sed_append_after 133inserts after line 133 → file grows by 1 line.sed_append_after 248now targets what was originally line 247, not 249.
Fix by either processing insertions bottom-up (highest line number first) or incrementing subsequent targets:
Proposed fix (bottom-up ordering)
"closte-helper.sh")
# Lines 134, 249
- sed_append_after 133 ' return 0' "$file"
- sed_append_after 248 ' return 0' "$file"
+ sed_append_after 248 ' return 0' "$file"
+ sed_append_after 133 ' return 0' "$file"
;;
"cloudron-helper.sh")
# Lines 74, 202
- sed_append_after 73 ' return 0' "$file"
- sed_append_after 201 ' return 0' "$file"
+ sed_append_after 201 ' return 0' "$file"
+ sed_append_after 73 ' return 0' "$file"
;;
...
"dns-helper.sh")
# Lines 95, 259
- sed_append_after 94 ' return 0' "$file"
- sed_append_after 258 ' return 0' "$file"
+ sed_append_after 258 ' return 0' "$file"
+ sed_append_after 94 ' return 0' "$file"
;;By inserting at the later line first, earlier line numbers remain stable.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "closte-helper.sh") | |
| # Lines 134, 249 | |
| sed -i '133a\ return 0' "$file" | |
| sed -i '248a\ return 0' "$file" | |
| sed_append_after 133 ' return 0' "$file" | |
| sed_append_after 248 ' return 0' "$file" | |
| ;; | |
| "cloudron-helper.sh") | |
| # Lines 74, 202 | |
| sed -i '73a\ return 0' "$file" | |
| sed -i '201a\ return 0' "$file" | |
| sed_append_after 73 ' return 0' "$file" | |
| sed_append_after 201 ' return 0' "$file" | |
| ;; | |
| "coolify-helper.sh") | |
| # Line 236 | |
| sed -i '235a\ return 0' "$file" | |
| sed_append_after 235 ' return 0' "$file" | |
| ;; | |
| "dns-helper.sh") | |
| # Lines 95, 259 | |
| sed -i '94a\ return 0' "$file" | |
| sed -i '258a\ return 0' "$file" | |
| sed_append_after 94 ' return 0' "$file" | |
| sed_append_after 258 ' return 0' "$file" | |
| ;; | |
| "closte-helper.sh") | |
| # Lines 134, 249 | |
| sed_append_after 248 ' return 0' "$file" | |
| sed_append_after 133 ' return 0' "$file" | |
| ;; | |
| "cloudron-helper.sh") | |
| # Lines 74, 202 | |
| sed_append_after 201 ' return 0' "$file" | |
| sed_append_after 73 ' return 0' "$file" | |
| ;; | |
| "coolify-helper.sh") | |
| # Line 236 | |
| sed_append_after 235 ' return 0' "$file" | |
| ;; | |
| "dns-helper.sh") | |
| # Lines 95, 259 | |
| sed_append_after 258 ' return 0' "$file" | |
| sed_append_after 94 ' return 0' "$file" | |
| ;; |
🤖 Prompt for AI Agents
In @.agents/scripts/comprehensive-quality-fix.sh around lines 66 - 84, The
sed_append_after calls use hardcoded line numbers and are executed top-down
which shifts subsequent targets; update each case block (e.g., the
"closte-helper.sh", "cloudron-helper.sh", "coolify-helper.sh", "dns-helper.sh"
blocks) to perform insertions bottom-up by ordering sed_append_after calls from
highest to lowest line number or by collecting target lines into an array and
sorting it descending before calling sed_append_after (ensuring the function
name sed_append_after remains unchanged and only the call order/loop logic is
changed).
|
|
||
| # Configuration | ||
| readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit | ||
| source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true |
There was a problem hiding this comment.
Silent fallback when shared-constants.sh fails to source leaves sed_inplace undefined.
Line 375 calls sed_inplace in apply_redactions(). If sourcing fails (file missing, permission issue), sed_inplace will be undefined and the script will crash at runtime with a "command not found" error — which is opaque to the user. Given set -euo pipefail on line 20, the script will exit immediately with no helpful message.
Consider either removing || true (so sourcing failure is caught early), or adding a guard:
Proposed guard
source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true
+if ! command -v sed_inplace &>/dev/null; then
+ sed_inplace() { if [[ "$(uname)" == "Darwin" ]]; then sed -i '' "$@"; else sed -i "$@"; fi; }
+fiAs per coding guidelines, .agents/scripts/*.sh scripts should focus on reliability, robustness, and error recovery mechanisms.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true | |
| source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true | |
| if ! command -v sed_inplace &>/dev/null; then | |
| sed_inplace() { if [[ "$(uname)" == "Darwin" ]]; then sed -i '' "$@"; else sed -i "$@"; fi; } | |
| fi |
🤖 Prompt for AI Agents
In @.agents/scripts/privacy-filter-helper.sh at line 33, The script silently
ignores failures when sourcing shared-constants.sh, which can leave the
sed_inplace function undefined and cause apply_redactions() to fail later;
remove the "|| true" fallback so sourcing errors surface, or add an explicit
guard after sourcing that checks for the sed_inplace symbol (e.g., test if the
function/command sed_inplace exists) and print a clear error and exit if
missing; ensure this guard references SCRIPT_DIR and shared-constants.sh so
maintainers can locate where the dependency is loaded and avoid the opaque
"command not found" failure under set -euo pipefail.
| # Configuration - resolve relative to this script's location | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit | ||
| readonly SCRIPT_DIR | ||
| source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true |
There was a problem hiding this comment.
Silent failure when sourcing a now-required dependency.
shared-constants.sh provides sed_inplace and sed_append_after, which are called later (lines 4227, 4303, 4392, 4396) with no local fallback. The 2>/dev/null || true will silently swallow a missing or broken source, leading to cryptic "command not found" errors deep in TODO.md update paths.
Consider at minimum logging a warning if the source fails, so debugging doesn't require tracing back from a sed wrapper that doesn't exist:
Suggested improvement
-source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true
+source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || log_warn "shared-constants.sh not found; sed_inplace/sed_append_after unavailable"Note: log_warn is defined on line 139, after this source line on 81. You'd need to either move the source below the log function definitions, or use a simpler echo >&2 fallback here.
As per coding guidelines, automation scripts should focus on "Clear logging and feedback" and "Error recovery mechanisms".
🤖 Prompt for AI Agents
In @.agents/scripts/supervisor-helper.sh at line 81, The script silently ignores
failure when sourcing shared-constants.sh (which defines sed_inplace and
sed_append_after) because of "2>/dev/null || true", causing later "command not
found" errors; remove the silent suppression and add an explicit warning if the
source fails (or move the source below the log_warn definition and use
log_warn), e.g., try sourcing shared-constants.sh without redirecting stderr and
on failure emit a clear message referencing shared-constants.sh and the missing
functions (sed_inplace, sed_append_after) and either exit or continue with a
documented fallback; ensure references to log_warn (or a temporary echo >&2
fallback placed before log_warn is defined) are used so the warning is visible.
| # Source shared constants (provides sed_inplace and other utilities) | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit | ||
| source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true |
There was a problem hiding this comment.
Critical: sed_inplace undefined during release would corrupt the release process.
This is the release-critical script (version-manager.sh release [major|minor|patch]). If shared-constants.sh fails to source, sed_inplace calls in update_version_in_files() (lines 422, 433, 444, 455, 471, 490) and auto_mark_tasks_complete() (lines 708, 711) will fail mid-release, potentially leaving version files in an inconsistent state.
For this script specifically, I'd recommend either failing fast or including an inline fallback:
Option A: Fail fast (preferred for release tooling)
# Source shared constants (provides sed_inplace and other utilities)
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit
-source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true
+source "$SCRIPT_DIR/shared-constants.sh" || { echo "[ERROR] Failed to source shared-constants.sh" >&2; exit 1; }Option B: Inline fallback
source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true
+if ! command -v sed_inplace &>/dev/null; then
+ sed_inplace() { if [[ "$(uname)" == "Darwin" ]]; then sed -i '' "$@"; else sed -i "$@"; fi; }
+fiAs per coding guidelines, .agents/scripts/version-manager.sh is the release pipeline entry point and should prioritize reliability and proper error recovery.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Source shared constants (provides sed_inplace and other utilities) | |
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit | |
| source "$SCRIPT_DIR/shared-constants.sh" 2>/dev/null || true | |
| # Source shared constants (provides sed_inplace and other utilities) | |
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit | |
| source "$SCRIPT_DIR/shared-constants.sh" || { echo "[ERROR] Failed to source shared-constants.sh" >&2; exit 1; } |
🤖 Prompt for AI Agents
In @.agents/scripts/version-manager.sh around lines 22 - 24, The script sources
shared-constants.sh to obtain sed_inplace but does not handle a failed source;
update_version_in_files and auto_mark_tasks_complete call sed_inplace and will
break the release if undefined. Fix by adding a fail-fast check immediately
after the source (verify sed_inplace is defined and executable) and abort with a
clear error if not, or alternatively implement a minimal inline fallback for
sed_inplace before any calls (declare a portable sed_inplace function used by
update_version_in_files and auto_mark_tasks_complete). Reference symbols:
shared-constants.sh, SCRIPT_DIR, sed_inplace, update_version_in_files,
auto_mark_tasks_complete.
…urce lines PR #480 (shared-constants adoption) added source lines to scripts that already had them from PR #479 (sed portability), causing double-sourcing. Under set -euo pipefail, the second source fails on readonly re-declaration, silently breaking supervisor-helper.sh (batch, help, all commands return 1). Fix: Add include guard (_SHARED_CONSTANTS_LOADED) so shared-constants.sh is safe to source multiple times. Also remove 5 duplicate source lines.
…urce lines (#483) PR #480 (shared-constants adoption) added source lines to scripts that already had them from PR #479 (sed portability), causing double-sourcing. Under set -euo pipefail, the second source fails on readonly re-declaration, silently breaking supervisor-helper.sh (batch, help, all commands return 1). Fix: Add include guard (_SHARED_CONSTANTS_LOADED) so shared-constants.sh is safe to source multiple times. Also remove 5 duplicate source lines.
1 participant
Summary
sed -iusage across 17 active scripts with the sharedsed_inplace()wrapper fromshared-constants.shsed_append_after()toshared-constants.shfor portable line insertion (BSD sedacommand has different syntax than GNU)sed_inplacedefinitions by sourcingshared-constants.shinsteadProblem
BSD sed (macOS) requires
sed -i ''while GNU sed (Linux/CI) requiressed -iwith no argument. Multiple scripts used one or the other, causing silent failures or errors on the other platform. Some scripts also usedsed -i.tmp/sed -i.bakwhich left orphan backup files.Changes by Category
shared-constants.shsed_append_after()for portable line insertionagent-test-helper.sh,privacy-filter-helper.sh,quality-fix.sh,security-helper.sh,supervisor-helper.sh,auto-version-bump.sh,version-manager.shsed_inplace()withsource shared-constants.shcomprehensive-quality-fix.sh,mass-fix-returns.shsed -iwithsed_inplace/sed_append_aftercoderabbit-cli.sh,readme-helper.sh,sonarcloud-autofix.sh,aidevops.sh,unstract-helper.sh,watercrawl-helper.shsed_inplace(no leftover temp files)supervisor-helper.shsed -i 'Na\...'withsed_append_afterwebhosting-helper.shsedinstruction now shows correct syntax per platformaidevops.shsed_inplace()(can't depend on.agents/being available)Not Changed
setup.sh: Already uses correct BSD-then-GNU fallback pattern (sed -i '' ... || sed -i ...)_archive/scripts: Not actively used, left as-iscloudron-app-packaging.mdusessed -icorrectly (runs inside Linux containers)Testing
sed_inplaceworks on macOS with basic substitution and-Eflagsed_append_aftercorrectly inserts lines with proper newlines on macOSCloses #440
Summary by CodeRabbit
Release Notes
Refactor
Chores