Skip to content

t3496: address PR #807 regex escaping feedback #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-solovyev merged 1 commit into from
Mar 14, 2026
Merged

t3496: address PR #807 regex escaping feedback #4747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .agents/scripts/supervisor-archived/issue-sync.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,10 +1769,13 @@ check_task_already_done() {

# Check 2: Are there merged commits referencing this task ID?
# IMPORTANT: Use word-boundary matching to prevent t020 matching t020.6.
# Escaped task_id for regex: dots become literal dots.
local escaped_task_regex
escaped_task_regex=$(printf '%s' "$task_id" | sed 's/\./\\./g')
# grep -w uses word boundaries but dots aren't word chars, so for subtask IDs
# like t020.1 we need a custom boundary: task_id followed by non-digit or EOL.
# This prevents t020 from matching t020.1, t020.2, etc.
local boundary_pattern="${task_id}([^.0-9]|$)"
local boundary_pattern="${escaped_task_regex}([^.0-9]|$)"

local commit_count=0
commit_count=$(git -C "$project_root" log --oneline -500 --all --grep="$task_id" 2>/dev/null |
Expand All @@ -1785,7 +1788,7 @@ check_task_already_done() {
completion_evidence=$(git -C "$project_root" log --oneline -500 --all --grep="$task_id" 2>/dev/null |
grep -E "$boundary_pattern" |
grep -iE "\(#[0-9]+\)|PR #[0-9]+ merged" |
grep -ivE "add ${task_id}|claim ${task_id}|mark ${task_id}|queue ${task_id}|blocked" |
grep -ivE "add ${escaped_task_regex}|claim ${escaped_task_regex}|mark ${escaped_task_regex}|queue ${escaped_task_regex}|blocked" |
head -1) || true
if [[ -n "$completion_evidence" ]]; then
log_info "Pre-dispatch check: $task_id has completion evidence: $completion_evidence" >&2
Expand Down
Loading